CLDR-17758 DDL: expand VettingViewerSummary for unaffiliated TC to all non-TC locales #3822
Conversation
| LocalesWithExplicitLevel cldrLocale = | ||
| new LocalesWithExplicitLevel(Organization.cldr, desiredLevel); | ||
|
|
||
| // TODO: another hack, unaffiliated gets everything |
There was a problem hiding this comment.
"TODO" should have a ticket number and clarify what needs to be done, otherwise just a comment not a "TODO"
There was a problem hiding this comment.
The todo is not needed here. I'll remove it.
srl295
changed the title
srl295
changed the title
…l non-TC locales - also move TimeDiff routines out to a new class
srl295
force-pushed
the
cldr-16087/expand-vvs-to-all-locales-for-unaffiliated
branch
from
6d4489a to
9707cdf
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@btangmu didn't realize i had already closed that PR |
| @@ -1084,6 +1084,27 @@ private void writeSummaryTable( | |||
|
|
|||
| private Map<String, String> getSortedNames(Organization org, Level desiredLevel) { | |||
| Map<String, String> sortedNames = new TreeMap<>(CLDRConfig.getInstance().getCollator()); | |||
| LocalesWithExplicitLevel cldrLocale = | |||
| new LocalesWithExplicitLevel(Organization.cldr, desiredLevel); | |||
There was a problem hiding this comment.
This is a TC user in the unaffiliated locales, right?
There was a problem hiding this comment.
It's a user already allowed to access priority items summary.
There was a problem hiding this comment.
I don't understand this code. The local variable cldrLocale seems to be assigned a value that is never used?
There was a problem hiding this comment.
@btangmu Thanks! Actually this looks like a copy and paste error from my previous PR, i'll remove it.
| if (org == Organization.unaffiliated && desiredLevel == Level.BASIC) { | ||
| for (String localeID : cldrFactory.getAvailable()) { | ||
| final CLDRLocale loc = CLDRLocale.getInstance(localeID); | ||
| if (SubmissionLocales.isTcLocale(loc)) continue; // skip TC locales |
There was a problem hiding this comment.
Once this is in place,
- the Priority Items should have all and only those locales that are in Organization.cldr - Organization.special.
- This list should include all and only those locales that are not in the Priority items.
There was a problem hiding this comment.
In particular, if a locale has any errors (that are not duplicates of a parent locales errors), they should be listed in one of the two lists.
There was a problem hiding this comment.
I didn't modify the non DDL list. Is it already correct?
There was a problem hiding this comment.
The "normal" code is here
There was a problem hiding this comment.
In particular, if a locale has any errors (that are not duplicates of a parent locales errors), they should be listed in one of the two lists.
Could we include this under the separate ticket about deduplicating errors https://unicode-org.atlassian.net/browse/CLDR-17743 ? This particular PR has a more limited scope, that simply having a way to get DDL reports at all.
There was a problem hiding this comment.
Yes, the deduping can be separate.
CLDR-17758
as an Unaffiliated TC, TC can request a Priority Items Summary that includes ONLY non-TC locales.
also split out Time Calc to improve the remaining time calculation for priority items
This PR completes the ticket.
Re-do of #3133
ALLOW_MANY_COMMITS=true