CLDR-17754 added Samogitian language #3818
Conversation
|
|
There was a problem hiding this comment.
It's really exciting to see this language added to CLDR :D Instead of adding everything all at once -- let's do it incrementally. See this pull request where I'm just adding the core data for Haitian Creole: #3948 -- Can you trim off most of the changes to sgs.xml in this diff to just the code data?
Once it's in the system we can contribute the time values in the Survey tool in the v47 window later this fall -- that tool has lots of assistance including validation.
Collation and casing and probably fine to add in this diff. I'm not so familiar w/ that code myself but it should generally be fine.
Also there are some other validation errors like that the pull request & commit should start w/ your Jira Ticket number. The Jira ticket does need to get reviewed but I tagged it so it should get review now.
zordsdavini
changed the title
|
I checked errors and have problem We have letter "ė̄" (ė with macron or e with dot above and macron), ex.: gerė̄jē. Mostly we write it with ė and adding macron (\u0304). Unicode doesn't have such single letter and didn't want to add when we asked to do that. What should we do here? |
|
Any sequence of characters can be included with {...}. For example,
{ė\u0304}
…On Sun, Aug 11, 2024 at 12:08 PM Arnas Udovič ***@***.***> wrote:
I checked errors and have problem
/home/runner/work/cldr/cldr/common/main/sgs.xml:18:110: error
sgs [Samogitian] error ▸Core_Data|Alphabetic_Information|Characters_in_Use|Main_Letters◂ 〈[a b c d e f g h i j k l m n o p q r s t u v w x y z]〉 【】 〈[aā b c č d eē ėė̄ f g h iī j k l m n oō p r s š t uū v z ž]〉 «=» 【】 ⁅illegal characters in exemplars⁆ ❮Error: Should be limited to (specific-script - uppercase - invisibles + İ); thus not contain: [\u0304]❯ https://st.unicode.org/cldr-apps/v#/sgs//7ed88347aa1b55ed
Error: Error: Should be limited to (specific-script - uppercase - invisibles + İ); thus not contain: [\u0304]
We have letter "ė̄" (ė with macron or e with dot above and macron), ex.:
gerė̄jē. Mostly we write it with ė and adding macron (\u0304). Unicode
doesn't have such single letter and didn't want to add when we asked to do
that. What should we do here?
And we have keylayout with macron as separate key, so all ā, ē, ī, ō,
ė̄, ū we can write in combination with \u0304
—
Reply to this email directly, view it on GitHub
<#3818 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMDRZXHHQGDQHDO6DOLZQ6ZBBAVCNFSM6AAAAABJVXPOASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSHA2TQNRUHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Should I add something more or do something because of failed build? The error looks very unrelated but maybe I am wrong? |
|
@srl295 Can you advise on test failures being reported here? |
|
@srl295 is this branch merged or just deleted? |
srl295
changed the title
|
@zordsdavini Did not see this one (i thought only @conradarcturus was using that branch) can you fix your commit so that it doesn't have the colon in it? If you click Details you can choose the Squash option there. |
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@srl295 tried to fix. I hope I did it correctly |
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
CLDR-17754
ALLOW_MANY_COMMITS=true