CLDR-16835 fix phase check for adding items

[srl295]

• adding items was using the overall phase instead of the specific phase

CLDR-16835

• This PR completes the ticket.

ALLOW_MANY_COMMITS=true

[macchiati]

Let's get this pushed this morning.

…

On Thu, Jun 20, 2024, 08:01 Tom Bishop ***@***.***> wrote: ***@***.**** approved this pull request. — Reply to this email directly, view it on GitHub <#3816 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMFUY6B27JGI2O3SQRLZILVC5AVCNFSM6AAAAABJUEBREOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZQGY4TCNRRHA> . You are receiving this because your review was requested.Message ID: ***@***.***>

[btangmu]

Error: TestSTFactory.TestVotePerf:470->runDataDrivenTest:486 Unexpected exception: org.unicode.cldr.web.SurveyException: Status action is forbidden: FORBID_UNLESS_DATA_SUBMISSION

[macchiati]

Once it works, of course.

…

On Thu, Jun 20, 2024, 08:13 Tom Bishop ***@***.***> wrote: Error: TestSTFactory.TestVotePerf:470->runDataDrivenTest:486 Unexpected exception: org.unicode.cldr.web.SurveyException: Status action is forbidden: FORBID_UNLESS_DATA_SUBMISSION — Reply to this email directly, view it on GitHub <#3816 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMFV5YU5RPT2GGWVFW3ZILWS5AVCNFSM6AAAAABJUEBREOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQHE2TCMZTGQ> . You are receiving this because your review was requested.Message ID: ***@***.***>

[btangmu]

        // Allow items if submission
        if (this == Phase.SUBMISSION || isUnitTest()) {
            return StatusAction.ALLOW;
        }

surprising if isUnitTest() returns false in this context?

[srl295]

working on it

[btangmu]

org.unicode.cldr.web.SurveyException: Status action is forbidden: FORBID_UNLESS_DATA_SUBMISSION
at org.unicode.cldr.web.api.VoteAPIHelper.getHandleVoteResponse(VoteAPIHelper.java:521)
at org.unicode.cldr.web.DataDrivenSTTestHandler.handleElementApivote(DataDrivenSTTestHandler.java:468)
at org.unicode.cldr.web.DataDrivenSTTestHandler.handlePathValue(DataDrivenSTTestHandler.java:83)
at org.unicode.cldr.util.XMLFileReader$MyContentHandler.endElement(XMLFileReader.java:439)
...
...
at org.unicode.cldr.util.XMLFileReader.read(XMLFileReader.java:147)
at org.unicode.cldr.web.TestSTFactory.runDataDrivenTest(TestSTFactory.java:486)
at org.unicode.cldr.web.TestSTFactory.TestVotePerf(TestSTFactory.java:470)

[srl295]

Took some digging but PTAL

[srl295]

Could I get someone else to merge/drive this once it passes and is reviewed? Have to jump off for some time.

[macchiati]

It passed, so I reviewed and will merge it. We'll need to test it out on smoke test once it appears there, to make sure it works. I will be able to look at it between 10:00 and 11:00. If it works, then I can do a quick sanity check and push.

…

On Thu, Jun 20, 2024 at 9:10 AM Steven R. Loomis ***@***.***> wrote: Could I get someone else to merge/drive this once it passes and is reviewed? Have to jump off for some time. — Reply to this email directly, view it on GitHub <#3816 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMEJULWJNYLU44RG7R3ZIL5GPAVCNFSM6AAAAABJUEBREOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGA3DKMZQGU> . You are receiving this because your review was requested.Message ID: ***@***.***>

[Koh-8888]

Thanks