Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17689 Dashboard download has empty Category column #3791

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Jun 7, 2024

-Replace non-existent cat with comma-concatenated cats

-Example: Missing, Warning, Abstained

CLDR-17689

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Replace non-existent cat with comma-concatenated cats

-Example: Missing, Warning, Abstained
@btangmu btangmu self-assigned this Jun 7, 2024
@btangmu btangmu requested a review from srl295 June 7, 2024 15:28
@btangmu
Copy link
Member Author

btangmu commented Jun 7, 2024

While testing this I noticed that this loop can take a very long time, to the extent that the browser seems frozen:

  // Fetch all XPaths in parallel since it'll take a while
  cb(`Loading rows…`);
  const allXpaths = [];
  for (let dashEntry of entries) {
    if (dashEntry.section === "Reports") {
      continue; // skip this
    }
    allXpaths.push(dashEntry.xpstrid);
    try {
      await xpathMap.get(dashEntry.xpstrid);
    } catch (e) {
      throw Error(
        `${e}:  Could not load XPath for ${JSON.stringify(dashEntry)}`
      );
    }
  }

Seems like that should go in a separate module and be cached. There must be other places where the front end could use a mapping between xpstrid and xpath, and there are probably json responses that could be made smaller by reducing redundant data.

@btangmu btangmu merged commit 2ea0301 into unicode-org:main Jun 7, 2024
12 checks passed
@btangmu btangmu deleted the t17689_a branch June 7, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants