Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17566 converting index acknowledgments downloads #3785

Conversation

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue, otherwise looking good.

docs/site/index/language-support-levels Outdated Show resolved Hide resolved
macchiati
macchiati previously approved these changes Jun 6, 2024
@macchiati
Copy link
Member

Notes for the future:

  1. You need to have each commit start with precisely the characters below. We can fix this by squashing using a web tool, but it is a bit of a pain

CLDR....

Eg

CLDR-17566 converting index acknowledgments downloads

  1. I sent you a note about the text diffs.
  2. Probably best to do this in chunks of up to 6(ish) files. Makes it easier to split reviews.

@macchiati
Copy link
Member

Ah, I remembered. You will have to squash this because I don't have access to your branch.

…-format-data, language-support-levels, locale-coverage, and requesting-additions to md

Also changed file to markdown in separate commit but squashed with this one.
@chpy04 chpy04 force-pushed the CLDR-17566-Converting-Index-Acknowledgments-Downloads branch from f1aff91 to 8464ced Compare June 7, 2024 00:31
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@chpy04
Copy link
Contributor Author

chpy04 commented Jun 7, 2024

Ok let me know if that is good now. Also on the next batch I will try out using the github diff with a temp folder, so we can see how that goes.

@macchiati
Copy link
Member

Hmmm. That's not working. You might have to create another PR with these files.

@srl295 srl295 changed the title Cldr 17566 converting index acknowledgments downloads CLDR-17566 converting index acknowledgments downloads Jun 7, 2024
@srl295
Copy link
Member

srl295 commented Jun 7, 2024

Hmmm. That's not working. You might have to create another PR with these files.

Just needed the PR title fixed. I fixed it.

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR includes 2 class files CheckDates$... Once you remove those, I can approve and merge.

@srl295
Copy link
Member

srl295 commented Jul 15, 2024

@chpy04 is this one obsolete? or does it need squash?

@chpy04 chpy04 force-pushed the CLDR-17566-Converting-Index-Acknowledgments-Downloads branch from 7c561a6 to b5ff76e Compare July 16, 2024 00:57
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@chpy04
Copy link
Contributor Author

chpy04 commented Jul 16, 2024

@srl295 needed squash, should be good now

@srl295 srl295 merged commit 5d57815 into unicode-org:main Aug 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants