Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17263 add zh-Latn #3758

Merged
merged 2 commits into from
May 30, 2024
Merged

CLDR-17263 add zh-Latn #3758

merged 2 commits into from
May 30, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented May 28, 2024

CLDR-17263

add:

ALLOW_MANY_COMMITS=true

@srl295 srl295 force-pushed the cldr-17263/zh-latn branch from d9f2a1d to eefca7d Compare May 28, 2024 23:07
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/zh_Latn.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 added the ddl DDL-SC specific work label May 29, 2024
@srl295 srl295 self-assigned this May 29, 2024
- include chars from pinyin zh-Latn
@srl295 srl295 requested review from emily-roth and DavidLRowe May 30, 2024 00:10
@srl295 srl295 marked this pull request as ready for review May 30, 2024 00:33
@srl295 srl295 requested a review from a team May 30, 2024 00:33
@srl295
Copy link
Member Author

srl295 commented May 30, 2024

Ready.

@DavidLRowe
Copy link
Contributor

It might be clearer in the main exemplar to use èéê rather than è-ê, but not a big deal. In fact, it probably gets normalized at some later point, so don't bother changing here.

The "numbers" exemplar generally includes decimal separator and grouping separator, and often plus, minus and percentage symbols. If these are not added to this exemplar, will the vetter be blocked from entering them in the Survey Tool?

For reference, zh.xml has:
[\- ‑ , . % ‰ + 0 1 2 3 4 5 6 7 8 9 〇 一 七 三 九 二 五 八 六 四]

Other than that, it seems fine.

@srl295
Copy link
Member Author

srl295 commented May 30, 2024 via email

Copy link
Contributor

@DavidLRowe DavidLRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srl295 srl295 merged commit 3568dce into unicode-org:main May 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ddl DDL-SC specific work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants