-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17993 Update spotless to 2.43 and google-java-style 1.22 to support Java 21+ #3757
Conversation
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do this now. maybe at release. I'm concerned about disruption to in-flight PRs
That's fine. Feel free to merge whenever you think it will be least disruptive. |
2d023d8
to
c310f45
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
b3b4828
to
3079942
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
3079942
to
dbf1b04
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
@srl295 When is a good time to merge? To cause the least disruption, I think either: 1) the last commit before cutting a release, or 2) the first commit at the beginning of a new release. I'll leave it to you. I can help keep this PR up to date until then. If not sometime like the above, then there won't be a better time to wait for in order to merge. |
Probably right after v46 is cut. |
@srl295 It's almost that time. I'm about to cut ICU v76. Merge when it is convenient. |
Thanks for the approval. Given that v46 is merged, and the Jira ticket was for a v46 BRS task, I'm going to update the PR to refer to the equivalent v47 Jira ticket. |
dbf1b04
to
b3ba218
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
(see: unicode-org/unicodetools#828)
CLDR-17993 - catch-all ticket for v47 dependency updates
ALLOW_MANY_COMMITS=true