CLDR-17582 Cleanup English annotations #3751
Conversation
|
The term [eyes] doesn't distinguish much among smilies!
But I don't think that is a showstopper.
…____
What might be useful is a report that mapped search keyword to emoji?
On Fri, May 24, 2024, 14:49 Fredrik ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In common/annotations/en.xml
<#3751 (comment)>:
> <annotation cp="🫠" type="tts">melting face</annotation>
<annotation cp="😉">face | flirt | heartbreaker | sexy | slide | tease | wink | winking | winks</annotation>
<annotation cp="😉" type="tts">winking face</annotation>
- <annotation cp="😊">blush | eye | face | glad | satisfied | smile | smiling | smiling face with smiling eyes</annotation>
+ <annotation cp="😊">blush | eye | eyes | face | glad | satisfied | smile | smiling</annotation>
Not sure if this is the emoji I would expect if searching for "eye" or
"eyes"?
—
Reply to this email directly, view it on GitHub
<#3751 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMAOXVJNTBIUL5PM6Z3ZD6YWLAVCNFSM6AAAAABIIGWDZ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZYGEYDENZTHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I think before we send this out to translation into some 70-80 languages, we should remove superfluous terms though, no? |
There was a problem hiding this comment.
I think there are too many superfluous individual terms with no relation to the emoji that will not be beneficial for the function. Before sending this out for translation in all the CLDR languages, we should clean that up to avoid a lot of confusion and wasted efforts, IMHO.
See what you think now; there is a fair amount of cleanup, so I think it is overall better than what we are showing to translators right now. |
|
Spec update LGTM |
|
Don't worry about the jira-ticket commit; will squash once it is approved. |
macchiati
force-pushed
the
CLDR-17582-Cleanup-English-annotations
branch
from
912e794 to
e5fc491
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
| <annotation cp="🫂" type="tts">people hugging</annotation> | ||
| <annotation cp="👪">child | family</annotation> | ||
| <annotation cp="👪" type="tts">family</annotation> | ||
| <annotation cp="🧑🧑🧒">family: adult, adult, child</annotation> <!-- 1F9D1 200D 1F9D1 200D 1F9D2 --> | ||
| <annotation cp="🧑🧑🧒">adult | child | family:</annotation> <!-- 1F9D1 200D 1F9D1 200D 1F9D2 --> |
There was a problem hiding this comment.
There is a left-over colon after "family" here.
There was a problem hiding this comment.
Ah, missed that one. I'd like to make that in a follow-on PR, because I've squashed this already. That, along with restoring Dracula, and removing Spock and Vulcan.
CLDR-17582
When reviewing, note that breaking up keywords and then alphabetizing means that phrases are distributed. Example:
We can't expect a line-by-line review, so please just spot-check looking for anything that is terrible: We can tweak the English later on before release; the goal here is to adhere more to the guidelines to lessen the chances vetters will be misled (though we caution them that they need to look at the associations in their languages, not English!)
ALLOW_MANY_COMMITS=true