CLDR-13523 add test for valid short day length; fix resulting data errs #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but can't approve til tomorrow
…On Tue, May 21, 2024, 20:36 Peter Edberg ***@***.***> wrote:
@pedberg-icu <https://github.com/pedberg-icu> requested your review on:
#3739 <#3739> CLDR-13523
<https://unicode-org.atlassian.net/browse/CLDR-13523> add test for valid
short day length; fix resulting data errs.
—
Reply to this email directly, view it on GitHub
<#3739 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMFQHQV6MKRBVDANQBLZDQHDTAVCNFSM6AAAAABICYX2KOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHA4DOOBQGQ3DIOI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Any TC member, please feel free to merge when approved, thanks. |
|
Per TC discussion 2024-05-22, decided to remove draft="contributed" and make the changes all approved. |
pedberg-icu
force-pushed
the
CLDR-13523-short-weekdays-cannot-be-longer-than-abbreviated
branch
from
2de4912 to
f8ac8f1
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
macchiati
approved these changes
May 22, 2024
pedberg-icu
deleted the
CLDR-13523-short-weekdays-cannot-be-longer-than-abbreviated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-13523
CheckDates had tests that abbreviated date symbols were no longer than wide (error), and that narrow date symbols were no longer than abbreviated (warning). But there was no test for short date symbols (only present in weekday names). Added a test that short days are no longer than abbreviated, and no shorter than narrow (both errors). Checked the with width both with a glyph width estimate (as used for the other tests) and a string length test, since the test was too sensitive otherwise (e.g. it failed on letter case differences).
Ran the test and fixed the resulting new data errors:
fil: replaced current standalone narrow (same as abbreviated) with format short (shorter)mai: replaced the one provided short value (which was too long) with ↑↑↑ like the other short values, to inherit from abbreviated.mgo: swapped the narrow (in standalone) and short (in format) forms to get the right length ordering.sa: replace short (English abbreviated names) with inheritance from abbreviated (in Sanskrit)so: replaced the one provided standalone short value (too long) with ↑↑↑ like the other standalone short values, to inherit from format short which inherits from format abbreviated.ALLOW_MANY_COMMITS=true