CLDR-10772 ST examples for month names, in appropriate format #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this is approved and tests pass, any TC member should feel free to merge so we can also review in smoketest. |
srl295
approved these changes
May 21, 2024
Comment on lines
+1118
to
+1123
| String checkPath = | ||
| "//ldml/dates/calendars/calendar[@type=\"" | ||
| + calendarId | ||
| + "\"]/dateTimeFormats/availableFormats/dateFormatItem[@id=\"" | ||
| + skeletons[skeletonIndex] | ||
| + "\"]"; |
There was a problem hiding this comment.
I wonder if we should have an XPathParts Builder designed for constructing XPaths in a loop with syntax checking (i.e. that the xpath remains valid).
There was a problem hiding this comment.
How many places would we use something like that?
|
Looks good in smoketest too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-10772
Add ST examples for month names showing them in appropriate context: format months in a format with day number (currently winning format for skeleton yMMMMd), and stand-alone months in a format without (currently winning format for skeleton yMMMM)
ALLOW_MANY_COMMITS=true