Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17199 Add missing time formats with h for several new locales #3732

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented May 19, 2024

CLDR-17199

  • This PR completes the ticket.

Add missing time formats using h in several new locales so ICU tests pass (locales that inherit from root and do not have time formats will get the root formats with H, which may not match the region time-cycle preference causing an ICU error).

  • css (for CA): Use the formats for en_CA but these inherit from en, so use those.
  • kxv_Deva, kxv_Orya, kxv_Telu (for IN): Use the formats for kxv (Latn).
  • zh_Hans_MY, zh_Hant_MY: Use Chinese-style time formats using (a before h, etc). These are in availableFormats e.g. for zh; but the are used as the standard formats in zh_Hans_SG so just copy from there.

Somewhere we have a CLDR ticket to add a CLDR-side test for this so we fix it before we get to ICU integration.

ALLOW_MANY_COMMITS=true

@pedberg-icu pedberg-icu self-assigned this May 19, 2024
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for contributed

@pedberg-icu pedberg-icu merged commit 8118765 into unicode-org:main May 19, 2024
7 checks passed
@pedberg-icu pedberg-icu deleted the CLDR-17199-time-formats-with-h-for-several-locales branch May 19, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants