-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-16668 Revise order of units #3698
base: main
Are you sure you want to change the base?
CLDR-16668 Revise order of units #3698
Conversation
Still draft, but feedback is useful. |
@@ -1851,28 +1833,41 @@ public enum UnitSystem { // TODO convert getSystems and SupplementalDataInfo to | |||
si_acceptable, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the order significant -- possibly affecting order of rows/pages in ST for example? If so, comment would be helpful, otherwise alphabetical order might be appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would affect the order of rows within the pages, grouping the quantities better.
|
||
public enum QuantityGroup { | ||
Duration("duration", "year-duration"), | ||
Length("length"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here again a brief comment explaining the significance of the ordering could be helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have a proposal for breaking apart the Units Other (which also ends up breaking apart a couple of others. It's just draft for now until we can discuss.
866a0aa
to
d12c1da
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
CLDR-16668
Still draft because I'd like to discuss with Tom.
tools/cldr-code/src/main/java/org/unicode/cldr/tool/ChartUnitConversions.java
tools/cldr-code/src/main/java/org/unicode/cldr/util/DtdData.java
tools/cldr-code/src/main/java/org/unicode/cldr/util/UnitConverter.java
tools/cldr-code/src/main/java/org/unicode/cldr/util/UnitPathType.java
tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestUnits.java
enhance one of the tests to also print information about the quantities, standard units, current ST Pages, ordering information, systems, etc.
This PR completes the ticket.
ALLOW_MANY_COMMITS=true