CLDR-17106 add more fixed candidate items #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- restructure DataPage / DiskDataCache to hold the candidate providers - add a FixedCandidateProvider structure, designed to allow quick additions of future fixed candidates.
|
|
srl295
commented
May 2, 2024
| private final PathHeader.Factory phf; | ||
| final SupplementalDataInfo sdi; | ||
|
|
||
| final List<FixedCandidateProvider> personNameProviders = |
There was a problem hiding this comment.
these are not locale dependent, so kept in a separate static list.
srl295
commented
May 2, 2024
Comment on lines
+73
to
+87
| class GrammarCandidateProvider extends PatternCacheCandidateProvider { | ||
| final GrammarInfo grammarInfo = sdi.getGrammarInfo(locale.getBaseName()); | ||
|
|
||
| public GrammarCandidateProvider() { | ||
| super("^//ldml/units/unitLength.*/unit.*gender"); | ||
| } | ||
|
|
||
| @Override | ||
| protected Collection<String> getCandidates() { | ||
| return grammarInfo.get( | ||
| GrammaticalTarget.nominal, | ||
| GrammaticalFeature.grammaticalGender, | ||
| GrammaticalScope.units); | ||
| } | ||
| } |
There was a problem hiding this comment.
this one is locale dependent depends on the supplementalDataInfo in the enclosing class
|
what are "fixed candidates"? |
Candidates are options during voting… Fix candidates means that you have a fixed list instead of being able to use the plus button |
|
In this pull request, I tried to write it so that it was easy to add more of these later |
macchiati
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17106
ALLOW_MANY_COMMITS=true