Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17582 BRS Add any necessary emoji annotations and collation info #3667

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented May 1, 2024

for the next Unicode Version

CLDR-17582

Following instructions in https://github.com/unicode-org/cldr/blob/main/docs/dev/generate-emoji-paths.md

Notes:

  • Needed an update for the emoji-test.txt parser.
  • The tooling didn't work for generating the annotations for adding to en.xml and root.xml,
    so I had to generate those by hand (well, with the assistance of a spreadsheet) from candidateData.txt
  • The emoji charts for v16 candidates are also not posted, so I couldn't cross check with those.

Will forward this PR to Ned also.

TODO: collation changes
Can come come in a later PR, because they don't block submission.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati macchiati force-pushed the CLDR-17582-BRS-Add-any-necessary-emoji-annotations-and-collation-info-for-candidates-for-the-next-Unicode-Version branch from 801810d to 6ef900e Compare May 1, 2024 06:22
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@macchiati macchiati changed the title BRS Add any necessary emoji annotations and collation info CLDR-17582 BRS Add any necessary emoji annotations and collation info May 1, 2024
@macchiati macchiati force-pushed the CLDR-17582-BRS-Add-any-necessary-emoji-annotations-and-collation-info-for-candidates-for-the-next-Unicode-Version branch from 6ef900e to ca72219 Compare May 1, 2024 06:23
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@macchiati macchiati requested review from AEApple and pedberg-icu May 1, 2024 06:25
@macchiati
Copy link
Member Author

The change in format for emoji-test also caused a bit test failure; will have to fix that.

@macchiati macchiati force-pushed the CLDR-17582-BRS-Add-any-necessary-emoji-annotations-and-collation-info-for-candidates-for-the-next-Unicode-Version branch from 923f57e to 9727e56 Compare May 1, 2024 23:36
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@nedley
Copy link

nedley commented May 1, 2024

I sent you the GenerateCldrData.java output with unicode-org/unicodetools#795, which should help avoid future spurious diffs.

@macchiati macchiati merged commit e89f253 into unicode-org:main May 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants