Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17600 BRS 7 Update language names #3666

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented May 1, 2024

CLDR-17600

As per BRS. This hasn't been done for a while. I updated 3 lists of languages:

  • go to supplemental/locale_coverage.html
  • Take all with computed level ≥ basic. Drop script/region and remove dups.
  • Put Target level= blank or starts with ‡ into attributeValueValidity id $languageExceptions.
  • Put others in $language.
  • Put older languages that didn't fit the above into $oldLanguages

Each list was canonicalized:
reorganized to remove overlaps and duplicates,
and put into alphabetical order with each new initial letter starting a row.

Notes:

  • This makes all the Basic+ languages be at Modern coverage
  • The translated names for languages below Basic won't be required for other locales to reach Modern.
  • It doesn't remove any translated names of languages that are already in CLDR
  • It does reorganize some of the languages, and makes the variable names match their contents, semantically.

If you want to see the names of $oldLanguages, go to https://util.unicode.org/UnicodeJsps/languageid.jsp?a=aa+ace+ada+ady+ain+ale+alt+anp+arp+ars+atj+av+awa+ay+ban+bi+bin+bla+bug+cay+ch+chk+chm+chp+chy+clc+crg+crj+crk+crl+crm+crr+crs+dak+dar+dgr+dzg+efi+eka+fj+fon+frc+gan+gil+gor+gwi+hai+hak+hax+hil+hmn+hsn+ht+hup+hur+hz+iba+ibb+ikt+ilo+inh+kac+kbd+kfo+kha+kj+kmb+kr+krc+krl+kru+kum+kv+kwk+lad+lez+li+lil+lld+lou+loz+lsm+ltg+lua+lun+lus+mad+mag+mak+men+mh+min+moe+mos+mwl+na+nan+nap+nb+new+ng+nia+niu+nog+ojb+ojc+ojs+ojw+oka+pag+pam+pau+pqm+quc+rap+rar+rup+sad+sba+sco+slh+sm+sma+smj++sms+snk+srn+str+suk+swb+sy+tce+tem+tet+tgx+tht+tlh+tli+ttm+tum+tvl+ty+udm+umb+war+wuu+xal+ybb

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

ids.add(parts[1]);
if (!value.inRoot) {
missing.add(parts[1]);
}
}
}
if (!assertEquals(
"Language subtags that are in a CLDR locale's ID are in root ("
"Language subtags in a locale's ID must be in one of the attributeValueValidity.xml $language* sets, typically $languageNonTcLtBasic ("
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there also a test that warns if a locale is being removed from a TC org's language set that it needs to be changed to be in the non-TC org Basic or higher list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't, and that's reasonable. But I'd like that to be a separate ticket, since we don't have to do it this release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, SGTM!

@macchiati macchiati requested a review from AEApple May 1, 2024 22:28
@macchiati
Copy link
Member Author

Can someone approve this?

srl295
srl295 previously approved these changes May 2, 2024
AEApple
AEApple previously approved these changes May 2, 2024
@macchiati macchiati dismissed stale reviews from AEApple and srl295 via e3b0e3a May 2, 2024 17:03
@macchiati macchiati force-pushed the CLDR-17600-BRS-7-Update-language-names branch from e3b0e3a to df97618 Compare May 2, 2024 17:03
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@macchiati macchiati requested review from srl295 and AEApple May 2, 2024 17:04
@macchiati
Copy link
Member Author

Had to resolve merge conflicts; can someone rubber-stamp? Only change is the addition of mhn (from #3665)

@macchiati macchiati requested a review from DavidLRowe May 2, 2024 17:06
@macchiati
Copy link
Member Author

Closing this PR, because the merge conflicts were too messy. Opening new version as #3680. Basically just test fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants