Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17424 v45: mfwg2 spec pour #3626

Merged
merged 9 commits into from
Apr 10, 2024
Merged

CLDR-17424 v45: mfwg2 spec pour #3626

merged 9 commits into from
Apr 10, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 10, 2024

CLDR-17424

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Apr 10, 2024
@srl295 srl295 marked this pull request as ready for review April 10, 2024 17:59
@srl295 srl295 requested review from macchiati and a team April 10, 2024 17:59
Copy link
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made suggestions to fix the broken heads. With those, this looks ready.

Local build on my machine is clean. Thanks for your help!!

docs/ldml/tr35-messageFormat.md Outdated Show resolved Hide resolved
docs/ldml/tr35-messageFormat.md Outdated Show resolved Hide resolved
docs/ldml/tr35-messageFormat.md Outdated Show resolved Hide resolved
docs/ldml/tr35-messageFormat.md Outdated Show resolved Hide resolved
docs/ldml/tr35-messageFormat.md Outdated Show resolved Hide resolved
docs/ldml/tr35-messageFormat.md Outdated Show resolved Hide resolved
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to tweak the h5 CSS to make them a bit larger, but that's separate from this.

@srl295 srl295 merged commit 534a927 into maint/maint-45 Apr 10, 2024
11 checks passed
@srl295 srl295 deleted the srl295/mfwg-v45-pour branch April 10, 2024 20:32
@srl295
Copy link
Member Author

srl295 commented Apr 10, 2024

I think we might want to tweak the h5 CSS to make them a bit larger, but that's separate from this.

There's a separate css file for this now, starting out blank.

@macchiati
Copy link
Member

Not yet built on https://cldr-smoke.unicode.org/spec/main/ldml/tr35-messageFormat.html. How often does the rebuild happen?

@srl295
Copy link
Member Author

srl295 commented Apr 10, 2024

Not yet built on https://cldr-smoke.unicode.org/spec/main/ldml/tr35-messageFormat.html. How often does the rebuild happen?

We're not in main anymore..

https://cldr-smoke.unicode.org/spec/maint-45/ldml/tr35-messageFormat.html

You can actually get there from https://unicode.org/reports/tr35/proposed.html also

@macchiati
Copy link
Member

macchiati commented Apr 10, 2024 via email

@macchiati
Copy link
Member

macchiati commented Apr 10, 2024 via email

pedberg-icu pushed a commit to pedberg-icu/cldr that referenced this pull request Apr 22, 2024
pedberg-icu pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants