Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17481 re-enable directly loading Test.html #3584

Merged
merged 2 commits into from
Mar 30, 2024
Merged

CLDR-17481 re-enable directly loading Test.html #3584

merged 2 commits into from
Mar 30, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 28, 2024

CLDR-17481

  • This PR completes the ticket.
  • run.sh not needed. Just npm run install build-test and then load Test.html

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Mar 28, 2024
srl295
srl295 commented Mar 28, 2024
View reviewed changes
Copy link
Member Author

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are other improvements that could be made, this is the easiest.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 requested a review from btangmu March 29, 2024 20:13
@srl295 srl295 merged commit d436fd7 into unicode-org:main Mar 30, 2024
11 checks passed
@srl295 srl295 deleted the cldr-17481/chai branch March 30, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btangmu btangmu btangmu approved these changes

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srl295 @btangmu