CLDR-16998 Fix Formatting #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AEApple
reviewed
Mar 28, 2024
| > replacement="und-alalc97">" | ||
| > | ||
| > result="ja-Latn-alalc97-fonipa" // note that CLDR canonical order of variants is alphabetical | ||
| > result="ja-Latn-alalc97-fonipa" |
There was a problem hiding this comment.
I thought source and result were also supposed to be enclosed?
There was a problem hiding this comment.
I just changed the items that are fragments of XML syntax; that is more consistent with the rest of the document. Adding a note to the ticket.
AEApple
reviewed
Mar 28, 2024
| @@ -3803,13 +3803,13 @@ A matching rule can be used to transform the source fields as follows | |||
|
|
|||
| _Example:_ | |||
|
|
|||
| > source=ja-Latn-fonipa-hepburn-heploc | |||
| > source="ja-Latn-fonipa-hepburn-heploc" | |||
There was a problem hiding this comment.
I thought he was also asking for formatting around this line?
| > | ||
| > replacement="und-alalc97">" | ||
| > result="ja-Latn-alalc97-fonipa" |
There was a problem hiding this comment.
I left the strings alone, and just changed the XML fragments (for more consistency with the rest of the document)
BTW, we definitely could use a scrub to fix the formatting overall, but that's a big-ticket item!
AEApple
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-16998
Took the suggestion to use monospacing in two of the suggested sections. The https://unicode.org/reports/tr35/#Key_And_Type_Definitions_ was more complicated, and would benefit less so that wasn't done.
ALLOW_MANY_COMMITS=true