Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17178 BRS fixes to COMMIT_METADATA.md #3578

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 27, 2024

CLDR-17178

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 requested a review from AEApple March 27, 2024 16:46
@srl295 srl295 self-assigned this Mar 27, 2024
@srl295 srl295 force-pushed the cldr-17178/misticketted branch from 9773c52 to 844a4e4 Compare March 27, 2024 23:51
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/COMMIT_METADATA.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 marked this pull request as ready for review March 27, 2024 23:51
@srl295
Copy link
Member Author

srl295 commented Mar 27, 2024

@AEApple CLDR-17229 may be a tool issue, because the cherrypick was merged 'backwards'

.github/COMMIT_METADATA.md Outdated Show resolved Hide resolved
.github/COMMIT_METADATA.md Outdated Show resolved Hide resolved
@srl295
Copy link
Member Author

srl295 commented Mar 29, 2024

This one as I mentioned is perhaps a commit checker bug. But probably a developer bug, because I did the cherry pick 'backwards'.

  • 73e4014 CLDR-17229 keyboard: v45 cherry-pick from maint-44 (#3383)
    - Authored by Steven R. Loomis [email protected]
    - Committed at 2023-11-03T18:51:10-05:00
    - COMMIT_METADATA.md: CLDR-17229
    - COMMIT_METADATA.md: kbd: cherry pick FROM maint-44
    - NOTE: excluded due to already being merged to old maint

if we want to make the ticket v44 that will quell the error.

@srl295 srl295 requested review from AEApple and a team March 29, 2024 17:53
@srl295 srl295 merged commit 801a29b into main Apr 2, 2024
11 checks passed
@srl295 srl295 deleted the cldr-17178/misticketted branch April 2, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants