CLDR-17339 Fix problem in ChartDeltaDtds that was skipping keyboard3

[macchiati]

CLDR-17339

• This PR completes the ticket.

ALLOW_MANY_COMMITS=true

[macchiati]

Question for you, @srl295 . There was a keyboard3 in v44. The change here fixes a bug, but also only goes back to v45 (eg no comparison to v44). That's ok if we want to forget about the v44 dtd.

If we want to retain the comparison we would change the following to have 44.

    keyboard3("keyboards/dtd/ldmlKeyboard3.dtd", "45.0", null, "../keyboards/3.0"),
    keyboardTest3("keyboards/dtd/ldmlKeyboardTest3.dtd", "45.0", null, "../keyboards/test");

Second question is: we are sometimes calling this Keyboard 2.0 (since it is a breaking change), but we have keyboard3. Should we publicly call it Keyboard 3.0?

[srl295]

Question for you, @srl295 . There was a keyboard3 in v44. The change here fixes a bug, but also only goes back to v45 (eg no comparison to v44). That's ok if we want to forget about the v44 dtd.

I don't think there's any value to comparing to v44 here.

If we want to retain the comparison we would change the following to have 44.

    keyboard3("keyboards/dtd/ldmlKeyboard3.dtd", "45.0", null, "../keyboards/3.0"),
    keyboardTest3("keyboards/dtd/ldmlKeyboardTest3.dtd", "45.0", null, "../keyboards/test");

Second question is: we are sometimes calling this Keyboard 2.0 (since it is a breaking change),

I don't think it's being called 2.0 now.

but we have keyboard3. Should we publicly call it Keyboard 3.0?

It's somewhat of the third revision, with 2.0 being CLDR-10926 (2018).

[srl295]

good catch, needed to be a version compare not a lexical compare

[srl295]

same

[macchiati]

Ok then this should work

…

On Tue, Feb 27, 2024, 16:28 Steven R. Loomis ***@***.***> wrote: Question for you, @srl295 <https://github.com/srl295> . There was a keyboard3 in v44. The change here fixes a bug, but also only goes back to v45 (eg no comparison to v44). That's ok if we want to forget about the v44 dtd. I don't think there's any value to comparing to v44 here. If we want to retain the comparison we would change the following to have 44. keyboard3("keyboards/dtd/ldmlKeyboard3.dtd", "45.0", null, "../keyboards/3.0"), keyboardTest3("keyboards/dtd/ldmlKeyboardTest3.dtd", "45.0", null, "../keyboards/test"); Second question is: we are sometimes calling this Keyboard 2.0 (since it is a breaking change), I don't think it's being called 2.0 now. but we have keyboard3. Should we publicly call it Keyboard 3.0? It's somewhat of the third revision, with 2.0 being CLDR-10926 <https://unicode-org.atlassian.net/browse/CLDR-10926> (2018). — Reply to this email directly, view it on GitHub <#3536 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMAI4UJAD3IOWAMH2ADYVZ23BAVCNFSM6AAAAABD5BR73OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXHE3DIMJQHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>