Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16108 cldr-json: mark -modern packages as deprecated #3517

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Feb 23, 2024

CLDR-16108

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295
Copy link
Member Author

srl295 commented Feb 23, 2024

Examples from the run:


PACKAGES.md

cldr-annotations-derived-modern

  • Note: Deprecated see CLDR-16465.
  • Character annotation data, including derived data. modern (deprecated)
  • NPM version

and in a README:

cldr-cal-dangi-modern

CLDR data for Dangi calendars.

Deprecated This package contains only the set of locales listed as modern coverage. Use cldr-cal-dangi-full and locale coverage data instead. The -modern packages are scheduled to be removed in v46, see CLDR-16465.

@srl295
Copy link
Member Author

srl295 commented Feb 23, 2024

I'll plan to mark the packages as deprecated when they are published also.

@srl295 srl295 force-pushed the srl295/cldr-16108/json-deprecatemodern branch from 563f9be to b06940e Compare February 23, 2024 23:10
macchiati
macchiati previously approved these changes Feb 24, 2024
pedberg-icu
pedberg-icu previously approved these changes Feb 24, 2024
Base automatically changed from srl295/cldr-17367/json-otherunits to main February 24, 2024 23:39
@srl295 srl295 dismissed stale reviews from pedberg-icu and macchiati February 24, 2024 23:39

The base branch was changed.

@srl295
Copy link
Member Author

srl295 commented Feb 24, 2024

ugh. Need a rubber stamp LGTM again because the base branch changed.

@srl295 srl295 force-pushed the srl295/cldr-16108/json-deprecatemodern branch from b06940e to e2e17f1 Compare February 26, 2024 15:05
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/resources/org/unicode/cldr/json/JSON_config_supplemental.txt is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 merged commit 03df02c into main Feb 26, 2024
15 checks passed
@srl295 srl295 deleted the srl295/cldr-16108/json-deprecatemodern branch February 26, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants