Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17311 Drop meatazone Macquarie, remove golden zone mapping for A… #3488

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

yumaoka
Copy link
Member

@yumaoka yumaoka commented Feb 1, 2024

…merica_Mountain in Mexico.

CLDR-17311

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@yumaoka
Copy link
Member Author

yumaoka commented Feb 1, 2024

@macchiati There are basically two small changes in metaZones.xml.

Dropping metazone Macquarie
In the past, we assigned a name dedicated for Macquarie Island with metazone Macquarie. This region belongs to Australia and using the same time zone with Tasmania. TZ DB assigns short zone ID AEST/AEDT. This is same as other Australian east coast zones, such as Australia/Sydney, Australia/Melbourne. There is no convincing reason to assign a special name for Macquarie. At some point, we mapped Australia/Macquarie to metazone Australia_Eastern, but I probably forgot to remove golden zone mapping. The issue CLDR-17311 reported the golden zone mapping is incompatible with metazone mapping data for Australia/Macquarie. The right action should be deleting the bad golden zone mapping. Also metazone Macquarie is no longer used by any zones, it should be dropped. We have translation for the metazone in locale files. This is why a lot of files are included in this PR.

Dropping golden zone mapping for America_Mountain in Mexico
America/Hermosillo is a zone with standard offset of UTC-7. In Mexico, UTC-7 zone is called as Pacific, instead of Mountain. We found this and created a metazone Mexico_Pacific if my memory is correct. Because the zone has been using UTC-7, we probably mapped this zone to metazone America_Mountain before. Then when we update the metazone mapping to Mexico_Pacific, we probably forgot to drop the golden zone mapping below.

<mapZone other="America_Mountain" territory="MX" type="America/Hermosillo"/>

At this point, no Mexican time zone uses metazone mapping to America_Mountain except a zone recently introduced - America/Ciudad_Juarez. This zone is used by the region near the US border. This zone used different offsets in the past until recently, it is not qualified as a golden zone. So the final solution is to drop the golden zone mapping for America_Mountain in Mexico.

I'd like to ask you to review coverageLevels.xml change for Macquarie is what we want. I'm not familiar with this area.

@yumaoka yumaoka merged commit 989104a into unicode-org:main Feb 1, 2024
7 checks passed
@yumaoka yumaoka deleted the metazone-fixes-17311 branch February 1, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants