Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-14913 Add Download XML button to Survey Tool #3477

Closed
wants to merge 1 commit into from

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Jan 30, 2024

-New back-end api/GenerateVxml.java, alternative to legacy admin-OutputAllFiles.jsp

-New front-end cldrGenerateVxml.mjs, GenerateVxml.vue

-Changes to OutputFileManager.java, support button/api as alternative to jsp

-Comments involving related VXML tickets

CLDR-14913

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-New back-end api/GenerateVxml.java, alternative to legacy admin-OutputAllFiles.jsp

-New front-end cldrGenerateVxml.mjs, GenerateVxml.vue

-Changes to OutputFileManager.java, support button/api as alternative to jsp

-Comments involving related VXML tickets
@btangmu
Copy link
Member Author

btangmu commented Jan 30, 2024

This still doesn't work correctly. The visual feedback isn't sufficient: it has a stop button, but says "Current status: WAITING" even while in progress. The browser never gets updated with the information that would get displayed using admin-OutputAllFiles.jsp...

I did most of this work last year. It hasn't been a high priority. Now that I'm working on https://unicode-org.atlassian.net/browse/CLDR-16946 it would be nice to have a better interface and not keep using admin-OutputAllFiles.jsp...

@btangmu btangmu self-assigned this Jan 30, 2024
@btangmu
Copy link
Member Author

btangmu commented Jan 30, 2024

console check error not related to this PR/ticket:

Caused by: com.google.common.util.concurrent.UncheckedExecutionException: java.util.ConcurrentModificationException
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2086)
at com.google.common.cache.LocalCache.get(LocalCache.java:4012)
at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:4035)
at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:5011)
at org.unicode.cldr.test.TestCache.getBundle(TestCache.java:121)
at org.unicode.cldr.test.ConsoleCheckCLDR.lambda$main$0(ConsoleCheckCLDR.java:627)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.TreeMap$KeySpliterator.forEachRemaining(TreeMap.java:2739)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
at java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:746)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)
Caused by: java.util.ConcurrentModificationException
at java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1043)
at java.base/java.util.ArrayList$Itr.next(ArrayList.java:997)
at org.unicode.cldr.test.CheckCLDR.setCldrFileToCheck(CheckCLDR.java:723)
at org.unicode.cldr.test.TestCache$TestResultBundle.(TestCache.java:45)
at org.unicode.cldr.test.TestCache$1.load(TestCache.java:109)
at org.unicode.cldr.test.TestCache$1.load(TestCache.java:105)
at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3571)
at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2313)
at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2190)
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2080)

@macchiati
Copy link
Member

macchiati commented Jan 31, 2024 via email

@btangmu
Copy link
Member Author

btangmu commented Jan 31, 2024

Can you file a ticket for this? We don't want it to get lost, and we'll need the ticket number anyway.

https://unicode-org.atlassian.net/browse/CLDR-17346

@btangmu
Copy link
Member Author

btangmu commented Sep 6, 2024

This PR is outdated. Later PRs were merged, with most of the same changes or better.

@btangmu btangmu closed this Sep 6, 2024
@btangmu btangmu deleted the t14913_c branch September 6, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants