Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17313 split out immutable DiskData in STFactory #3476

Merged
merged 2 commits into from
Feb 7, 2024
Merged

CLDR-17313 split out immutable DiskData in STFactory #3476

merged 2 commits into from
Feb 7, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jan 30, 2024

  • stuff we only want to calculate once, versus what can be expired from the cache.

CLDR-17313

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295
CLDR-17313 split out immutable DiskData in STFactory
1fc7753 
- stuff we only want to calculate once, versus what can be expired from the cache.
@srl295 srl295 self-assigned this Jan 30, 2024
@srl295 srl295 marked this pull request as ready for review February 6, 2024 19:33
@srl295 srl295 requested review from btangmu and macchiati February 6, 2024 19:34
btangmu
btangmu approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@btangmu btangmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@srl295 srl295 merged commit 34c862e into unicode-org:main Feb 7, 2024
10 checks passed
@srl295 srl295 deleted the cldr-17313/pathsForFileCache branch February 7, 2024 14:49
@Redwoodtj Redwoodtj mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btangmu btangmu btangmu approved these changes

@macchiati macchiati Awaiting requested review from macchiati

Assignees

@srl295 srl295

Labels
incomplete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srl295 @btangmu