CLDR-17327 speedup VoteResolver's transcript #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- skip String.format when unneeded - defer all transcript operations until needed measured as between a 5 and 10x speedup
macchiati
previously approved these changes
Jan 23, 2024
tools/cldr-code/src/main/java/org/unicode/cldr/util/DeferredTranscript.java
Show resolved
Hide resolved
btangmu
previously approved these changes
Jan 24, 2024
- add and correct some comments
|
This class could potentially have other uses, perhaps detailed explanations of error checks or things like that. Any time you don't know a priori whether a person is going to want to see the details or not. |
macchiati
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
measured as between a 5 and 10x speedup
CLDR-17327
ALLOW_MANY_COMMITS=true