CLDR-17314 intern across multiple locations #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
force-pushed
the
cldr-17313/xpath-intern
branch
from
8008826 to
145b379
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
changed the title
|
corrected ticket |
macchiati
requested changes
Jan 23, 2024
tools/cldr-code/src/main/java/org/unicode/cldr/util/CLDRFile.java
Outdated
Show resolved
Hide resolved
tools/cldr-code/src/main/java/org/unicode/cldr/util/StringId.java
Outdated
Show resolved
Hide resolved
|
Ah, good point.
…On Tue, Jan 23, 2024 at 1:47 PM Steven R. Loomis ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tools/cldr-code/src/main/java/org/unicode/cldr/util/CLDRFile.java
<#3461 (comment)>:
> @@ -3156,8 +3156,8 @@ public Set<String> getRawExtraPaths() {
if (extraPaths == null) {
extraPaths =
ImmutableSet.<String>builder()
- .addAll(getRawExtraPathsPrivate())
- .addAll(CONST_EXTRA_PATHS)
+ .addAll(CharUtilities.internAll(getRawExtraPathsPrivate()))
It's an Iterable<> interface. Was trying to avoid having to allocate
another copy of all of the strings. This way it's just pass through. But
you could use a lambda on a temporary object
—
Reply to this email directly, view it on GitHub
<#3461 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMBHAEF6SMYB4JPL6CDYQAVV5AVCNFSM6AAAAABCHUPETWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZZHE4TQNJVGU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
macchiati
approved these changes
Jan 23, 2024
btangmu
approved these changes
Jan 24, 2024
|
"Commit a814c25 is for CLDR-17313, but the PR is for CLDR-17314" -- probably a squash would fix that |
- Unit test to verify that CLDRFile paths are interned - interning in XPathTable and StringId
- don't intern in StringId - simplify intern logic with lambdas
srl295
force-pushed
the
cldr-17313/xpath-intern
branch
from
a814c25 to
91f7a7c
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17314
ALLOW_MANY_COMMITS=true