Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17282 Add currency attributes tz, to-tz and docs; use for currency changes from 2022-01-01 #3452

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Jan 15, 2024

CLDR-17282

  • This PR completes the ticket.
  1. For the currency element, add attributes tz and to-tz. Document these in the spec, along with note that implementations may want to convert the combination of date time and timezone to a UTC timestamp or equivalent for use as runtime data.

    • I made these @VALUE since they are not distinguishing attributes (but rather annotations for the to and from attributes); however they are not really like element values either. I also updated PathHeader accordingly.
  2. Update the supplemental currency data to use these new attributes for all currency transitions from 2022-01-01 onward. There were only two, for Croatia using tz Europe/Zagreb, and for Sierra Leone, using tz Africa/Freetown. Both of those zones are currently aliases in the backward file, but are still valid in CLDR I believe.

  3. I have filed ICU-22631 for the associated work in the cldr-icu converter.

ALLOW_MANY_COMMITS=true

@pedberg-icu pedberg-icu self-assigned this Jan 15, 2024
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only comment is if 'IANA timezone' should actually be CLDR timezone, including aliases and such.

@pedberg-icu
Copy link
Contributor Author

LGTM. Only comment is if 'IANA timezone' should actually be CLDR timezone, including aliases and such.

Thanks, I will investigate and file another PR against the same ticket if it needs changing.

@pedberg-icu pedberg-icu merged commit 75a12cd into unicode-org:main Jan 25, 2024
7 checks passed
@pedberg-icu pedberg-icu deleted the CLDR-17282-add-tz-for-currency-changes branch January 25, 2024 21:33
@pedberg-icu
Copy link
Contributor Author

LGTM. Only comment is if 'IANA timezone' should actually be CLDR timezone, including aliases and such.

Thanks, I will investigate and file another PR against the same ticket if it needs changing.

@srl295 OK, PR #3468 changes the timezone ID specification to specifically reference the CLDR canonical “long” time zone ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants