CLDR-17109 st: Actually remove the rest of Derby #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove derbyNotSupported(), db_Derby, AND db_Mysql AND getDBKind()
btangmu
approved these changes
Jan 10, 2024
| * see | ||
| * java.sql.Types | ||
| */ | ||
| private static final int db_UnicodeType = java.sql.Types.BLOB; |
There was a problem hiding this comment.
On first glance this seems to go beyond dropping derby -- does this potentially change the behavior when using mysql? Now I see setupSqlForServerType had override for mysql... so I'm assuming there's no actual change for mysql for this whole PR
There was a problem hiding this comment.
Yes it moves the overrides up. I'm trying to make it easier to see what the MySQL settings are.
| } | ||
| return sqlCount( | ||
| conn, | ||
| "select count(*) from information_schema.COLUMNS where table_name=? and column_name=?", |
There was a problem hiding this comment.
ideally all caps for the sql reserved words -- out of scope for this ticket though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove derbyNotSupported(), db_Derby, AND db_Mysql AND getDBKind()
CLDR-17109
ALLOW_MANY_COMMITS=true