Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17192 kbd: v45 Normalization docs #3445

Merged
merged 29 commits into from
Feb 26, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jan 9, 2024

CLDR-17192

Updates to the section on Normalization, with updates to other sections which link there.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Jan 9, 2024
@srl295 srl295 requested a review from a team January 22, 2024 23:57
@srl295 srl295 marked this pull request as ready for review January 22, 2024 23:59
@srl295
Copy link
Member Author

srl295 commented Jan 24, 2024

I'm thinking that the mention of grapheme clusters is out of order edit: corrected.

docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
@srl295 srl295 force-pushed the kbd/cldr-17192/kbdnormalization branch from 774e8c2 to 585e729 Compare January 26, 2024 22:28
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 force-pushed the kbd/cldr-17192/kbdnormalization branch from 585e729 to b8e1fb5 Compare January 26, 2024 22:30
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
docs/ldml/tr35-keyboards.md Outdated Show resolved Hide resolved
srl295 added a commit to srl295/cldr that referenced this pull request Jan 29, 2024
@srl295 srl295 requested a review from jahorton January 31, 2024 20:24
srl295 and others added 17 commits February 24, 2024 22:40
Update with beginning of algorithm
- includes review feedback

Co-authored-by: Mark Davis <[email protected]>
Co-authored-by: Marc Durdin <[email protected]>
- update to wording

Co-authored-by: Joshua Horton <[email protected]>
-  update to reorder processing discussion per review
- reorders -> reorder elements
- regenerate ToC
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/ldml/tr35-keyboards.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 requested review from macchiati and a team and removed request for rc-swag February 26, 2024 14:54
@srl295
Copy link
Member Author

srl295 commented Feb 26, 2024

I need another review due to having to rebase this because of conflicts. Thanks

@srl295
Copy link
Member Author

srl295 commented Feb 26, 2024

@unicode-org/cldr-tc can I get an approval for this rebase?

@srl295 srl295 merged commit 399aa7a into unicode-org:main Feb 26, 2024
7 checks passed
@srl295 srl295 deleted the kbd/cldr-17192/kbdnormalization branch February 26, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants