CLDR-7646 use TestCache everywhere #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
force-pushed
the
cldr-7646/testcache-everywhere
branch
from
09e3a1e to
567389d
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
force-pushed
the
cldr-7646/testcache-everywhere
branch
from
567389d to
d2071e8
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
force-pushed
the
cldr-7646/testcache-everywhere
branch
from
d120cc8 to
e514043
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
- update Factory subclasses to call registerXmlSource() - update STFactory
- No reason CldrVersion calls SDI when it can just use the static GEN_VERSION - add a test to make sure that all of the various version numbers are the same For: CLDR-9149
…essarily - move the header CSS into CLDRURLS, it really could go in surveytool.css or something.
- STFactory: notify on change when state changes, not just value - SurveyMain: extra print of ST Init failed stack - TestCache: add logging - Factory: lazy init TestCache
- CheckCoverage: improve accept() call - DataPage / STFactory: use all tests (.*), but filter out Coverage before sending to client
- add a constructor to CheckCLDR that takes just a CLDRLocale - move test exclusion in STFactory
srl295
force-pushed
the
cldr-7646/testcache-everywhere
branch
from
e514043 to
da03783
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
macchiati
previously approved these changes
Jan 6, 2024
|
missed a spot(less) |
macchiati
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-7646
Note: includes fix #3438(already merged)ALLOW_MANY_COMMITS=true