CLDR-17248 Enable creation of ST accounts for webdriver simulated users #3424
Conversation
-Simulated users have pseudo email addresses like [email protected] -New class AuthSurveyDriver -In Auth, if login fails, call AuthSurveyDriver to enable creation of account if appropriate -Only create simulated users if SurveyMain.isUnofficial, never on production server -Only create simulated users if CLDR_WEBDRIVER_PASSWORD is defined in cldr.properties
| } | ||
| if (user == null) { | ||
| user = AuthSurveyDriver.createTestUser(request.password, request.email); | ||
| } |
There was a problem hiding this comment.
this is a little awkward since UserRegistry.get sometimes throws LogoutException and sometimes just returns null without throwing an exception -- currently it throws LogoutException for a new webdriver user, but I didn't want to rely on that here, so this also handles the null return possibility
| if (user == null) { | ||
| return Response.status(403, "Login failed").build(); | ||
| throw new LogoutException(); |
There was a problem hiding this comment.
there's already a catch(LogoutException) below which returns Response.status(403, "Login failed").build()
if we returned that response directly here, the catch below would trigger an "unused" warning, and removing it would result in a many lines of code changing their indentation, and this change would look much larger than it really is
|
This goes together with unicode-org/cldr-apps-webdriver#31 |
-Simulated users have pseudo email addresses like [email protected]
-New class AuthSurveyDriver
-In Auth, if login fails, call AuthSurveyDriver to enable creation of account if appropriate
-Only create simulated users if SurveyMain.isUnofficial, never on production server
-Only create simulated users if CLDR_WEBDRIVER_PASSWORD is defined in cldr.properties
CLDR-17248
ALLOW_MANY_COMMITS=true