CLDR-17288 vagrant/ansible: fix for openliberty / mysql #3420

srl295 · 2023-12-16T00:13:45Z

CLDR-17288

this is just to get the build going again, CLDR-17279 will be for fixing docs etc.
had to update the Ubuntu version (which we need in CLDR-16735) because of build issues, but should be forward/backward compatible.
This PR completes the ticket.

Discussion: https://github.com/orgs/community/discussions/73013

ALLOW_MANY_COMMITS=true

jira-pull-request-webhook · 2023-12-16T00:14:23Z

Notice: the branch changed across the force-push!

tools/scripts/ansible/setup-playbook.yml is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2023-12-18T23:00:10Z

Notice: the branch changed across the force-push!

tools/scripts/ansible/Vagrantfile is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2023-12-19T16:57:46Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2023-12-20T21:48:12Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

- also up machine size to 8G

- was ignored since CLDR-14757

jira-pull-request-webhook · 2023-12-20T22:09:16Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2023-12-22T20:24:46Z

Notice: the branch changed across the force-push!

.github/workflows/ansible-lint.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2023-12-22T20:26:22Z

Notice: the branch changed across the force-push!

.github/workflows/ansible-lint.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2023-12-22T20:58:41Z

Notice: the branch changed across the force-push!

tools/scripts/ansible/Vagrantfile is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

- relates some to CLDR-16735

jira-pull-request-webhook · 2023-12-26T19:59:02Z

Notice: the branch changed across the force-push!

tools/scripts/ansible/cldr-apps-playbook.yml is now changed in the branch
tools/scripts/ansible/Vagrantfile is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2023-12-26T21:05:55Z

Notice: the branch changed across the force-push!

.github/workflows/ansible-lint.yml is different
tools/scripts/ansible/vagrant-playbook.yml is now changed in the branch
tools/scripts/ansible/Vagrantfile is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

srl295 · 2023-12-26T21:06:16Z

@btangmu I'm wondering if a better way to go about this would be to actually provision and setup an azure machine as part of the testing. then we could run tests against it, and then shut it down. This could let us even spin up a new machine on request for testing. I'll try using docker, though.

btangmu · 2023-12-27T18:17:56Z

"actually provision and setup an azure machine as part of the testing" -- do you mean to integrate github with azure?

jira-pull-request-webhook · 2024-01-05T21:29:27Z

Notice: the branch changed across the force-push!

.github/workflows/ansible-lint.yml is different
tools/scripts/ansible/vagrant-playbook.yml is no longer changed in the branch
tools/scripts/ansible/Vagrantfile is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

srl295 · 2024-01-05T22:29:47Z

@btangmu 'testprovision' now succeeds and prints:

ERROR this usually fails but we are ignoring the failure. Try it manually

Please review and then we can manually try vagrant up locally.

- Ref: CLDR-17297 for future enablement

jira-pull-request-webhook · 2024-01-05T22:33:28Z

Notice: the branch changed across the force-push!

.github/workflows/ansible-lint.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

- this affects new ST setups only. Would fail the first time only, each time.

- finally document how to deploy locally, no tomcat anymore! - This encompasses CLDR-17279

btangmu

LGTM except ourConn.commit() removal -- some callers use getDBConnection not getAConnection

tools/cldr-apps/src/main/java/org/unicode/cldr/web/XPathTable.java

- XPathTable should be called with an autoclose connection only

srl295 force-pushed the waslib branch from 3156b9d to f50efc8 Compare December 16, 2023 00:14

srl295 force-pushed the waslib branch from f50efc8 to 88757ec Compare December 18, 2023 23:00

srl295 self-assigned this Dec 18, 2023

srl295 requested a review from btangmu December 18, 2023 23:03

srl295 force-pushed the waslib branch from 88757ec to 7ec8c7c Compare December 19, 2023 16:57

srl295 force-pushed the waslib branch from 7ec8c7c to 20c4dfd Compare December 20, 2023 21:48

srl295 changed the title ~~CLDR-17288 vagrant/ansible: fix for openliberty / mysql~~ CLDR-17279 vagrant/ansible: fix for openliberty / mysql Dec 20, 2023

srl295 changed the title ~~CLDR-17279 vagrant/ansible: fix for openliberty / mysql~~ CLDR-17288 vagrant/ansible: fix for openliberty / mysql Dec 20, 2023

srl295 marked this pull request as ready for review December 20, 2023 22:08

srl295 added 2 commits December 20, 2023 16:09

CLDR-17288 vagrant/ansible: fix for openliberty / mysql

c5851e4

- also up machine size to 8G

CLDR-17288 re-enable ansible build

58d3a6b

- was ignored since CLDR-14757

srl295 force-pushed the waslib branch from 86b2c90 to 58d3a6b Compare December 20, 2023 22:09

srl295 force-pushed the waslib branch from 6af4e1f to 2e7c00c Compare December 22, 2023 20:24

srl295 force-pushed the waslib branch from 2e7c00c to 90ad26b Compare December 22, 2023 20:26

CLDR-17288 attempt to unbreak ansible

7ea6b4e

srl295 force-pushed the waslib branch from 90ad26b to 7ea6b4e Compare December 22, 2023 20:58

btangmu previously approved these changes Dec 23, 2023

View reviewed changes

CLDR-17288 update scripts some for jammy

f908319

- relates some to CLDR-16735

srl295 dismissed btangmu’s stale review via f908319 December 26, 2023 19:58

srl295 force-pushed the waslib branch from ebfb0e3 to f908319 Compare December 26, 2023 19:58

srl295 requested a review from btangmu December 26, 2023 20:00

srl295 mentioned this pull request Dec 26, 2023

CLDR-17492 gh:(deps): Bump ansible/ansible-lint-action from 6.2.1 to 6.17.0 #3131

Open

srl295 force-pushed the waslib branch from 79ac5bf to 4a56a26 Compare December 26, 2023 21:05

srl295 closed this Dec 26, 2023

srl295 reopened this Dec 26, 2023

CLDR-17288 skip ansible provision yet again

74f717d

srl295 force-pushed the waslib branch from 4a56a26 to 74f717d Compare January 5, 2024 21:29

CLDR-17288 ansible: make warning more clear

72dda8d

- Ref: CLDR-17297 for future enablement

srl295 force-pushed the waslib branch from 3099ee2 to 72dda8d Compare January 5, 2024 22:33

srl295 added 2 commits January 5, 2024 17:22

CLDR-17288 fix an XPathTable startup issue

654898f

- this affects new ST setups only. Would fail the first time only, each time.

CLDR-17288 update README for ansible

2df916e

- finally document how to deploy locally, no tomcat anymore! - This encompasses CLDR-17279

btangmu requested changes Jan 8, 2024

View reviewed changes

tools/cldr-apps/src/main/java/org/unicode/cldr/web/XPathTable.java Show resolved Hide resolved

CLDR-17288 fix issue with previous fix to XPathTable

a49e674

- XPathTable should be called with an autoclose connection only

srl295 requested a review from btangmu January 9, 2024 02:05

btangmu approved these changes Jan 9, 2024

View reviewed changes

srl295 merged commit a292ca8 into unicode-org:main Jan 9, 2024
12 checks passed

srl295 deleted the waslib branch January 9, 2024 15:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLDR-17288 vagrant/ansible: fix for openliberty / mysql #3420

CLDR-17288 vagrant/ansible: fix for openliberty / mysql #3420

srl295 commented Dec 16, 2023 •

edited

Loading

jira-pull-request-webhook bot commented Dec 16, 2023

jira-pull-request-webhook bot commented Dec 18, 2023

jira-pull-request-webhook bot commented Dec 19, 2023

jira-pull-request-webhook bot commented Dec 20, 2023

jira-pull-request-webhook bot commented Dec 20, 2023

jira-pull-request-webhook bot commented Dec 22, 2023

jira-pull-request-webhook bot commented Dec 22, 2023

jira-pull-request-webhook bot commented Dec 22, 2023

jira-pull-request-webhook bot commented Dec 26, 2023

jira-pull-request-webhook bot commented Dec 26, 2023

srl295 commented Dec 26, 2023 •

edited

Loading

btangmu commented Dec 27, 2023

jira-pull-request-webhook bot commented Jan 5, 2024

srl295 commented Jan 5, 2024

jira-pull-request-webhook bot commented Jan 5, 2024

btangmu left a comment

CLDR-17288 vagrant/ansible: fix for openliberty / mysql #3420

CLDR-17288 vagrant/ansible: fix for openliberty / mysql #3420

Conversation

srl295 commented Dec 16, 2023 • edited Loading

jira-pull-request-webhook bot commented Dec 16, 2023

jira-pull-request-webhook bot commented Dec 18, 2023

jira-pull-request-webhook bot commented Dec 19, 2023

jira-pull-request-webhook bot commented Dec 20, 2023

jira-pull-request-webhook bot commented Dec 20, 2023

jira-pull-request-webhook bot commented Dec 22, 2023

jira-pull-request-webhook bot commented Dec 22, 2023

jira-pull-request-webhook bot commented Dec 22, 2023

jira-pull-request-webhook bot commented Dec 26, 2023

jira-pull-request-webhook bot commented Dec 26, 2023

srl295 commented Dec 26, 2023 • edited Loading

btangmu commented Dec 27, 2023

jira-pull-request-webhook bot commented Jan 5, 2024

srl295 commented Jan 5, 2024

jira-pull-request-webhook bot commented Jan 5, 2024

btangmu left a comment

Choose a reason for hiding this comment

srl295 commented Dec 16, 2023 •

edited

Loading

srl295 commented Dec 26, 2023 •

edited

Loading