Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17284 v44.1 cldr-json: fix version number #3416

Merged
merged 1 commit into from
Dec 13, 2023
Merged

CLDR-17284 v44.1 cldr-json: fix version number #3416

merged 1 commit into from
Dec 13, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Dec 12, 2023

  • _cldrVersion was, recently, only having the major version (44 not 44.1)
  • validate semver of the package version
  • print a warning if the 'patch' version is nonzero (#.#.0)

CLDR-17284

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295
CLDR-17284 v44.1 cldr-json: fix version number
5dac221 
- _cldrVersion was, recently, only having the major version (44 not 44.1)
- validate semver of the package version
- print a warning if the 'patch' version  is nonzero (#.#.0)
@srl295 srl295 self-assigned this Dec 12, 2023
@srl295 srl295 requested review from sffc and btangmu December 12, 2023 22:44
@srl295 srl295 marked this pull request as ready for review December 12, 2023 22:44
@srl295 srl295 merged commit 1386955 into unicode-org:maint/maint-44 Dec 13, 2023
10 checks passed
@srl295 srl295 deleted the cldr-17284/cldr-json-version branch December 13, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btangmu btangmu btangmu approved these changes

@sffc sffc Awaiting requested review from sffc

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srl295 @btangmu