Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17248 Measure vote timing; remove obsolete debugging code #3407

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Dec 5, 2023

-Delete CLDR_TABLE_DEBUG_ZOOM and the block of code that depended on it

-Do not duplicate display of xpath in info panel that depended on CLDR_TABLE_DEBUG

CLDR-17248

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Delete CLDR_TABLE_DEBUG_ZOOM and the block of code that depended on it

-Do not duplicate display of xpath in info panel that depended on CLDR_TABLE_DEBUG
@btangmu
Copy link
Member Author

btangmu commented Dec 5, 2023

The duplicate xpath is shown in this screenshot:

image

If CLDR_TABLE_DEBUG was true, the xpath was shown twice in the info panel if the user clicked on the leftmost column ("code cell"). This feature doesn't seem very useful since the xpath is already shown at the bottom right corner. It seems better for CLDR_TABLE_DEBUG not to have visible effects except in the console. Also it depended on the complex legacy function cldrInfo.listen, whose "str" arg is otherwise usually null or empty, so this simplification may help pave the way to cleaning up and modernizing that code.

@btangmu btangmu self-assigned this Dec 5, 2023
@btangmu btangmu requested a review from srl295 December 5, 2023 16:21
@btangmu
Copy link
Member Author

btangmu commented Dec 5, 2023

I just noticed my branch has the wrong ticket number in it: t13970_d should have been t17248_d. I won't waste time fixing that, if that's OK

@btangmu btangmu merged commit 5c91532 into unicode-org:main Dec 5, 2023
11 checks passed
@btangmu btangmu deleted the t13970_d branch December 5, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants