CLDR-17248 Measure vote timing; log more times; fix warnings #3404
Conversation
-Make cldrTable.CLDR_TABLE_DEBUG true; log times to console -Make new cldrTable.CLDR_TABLE_DEBUG_ZOOM false; not clear whether still useful -Fix Chrome warnings, add id locale-search-input and input-add-translation -Fix Chrome warnings, move import statements to top of surveytool.css -Comments
| @@ -707,7 +735,7 @@ function updateRowCodeCell(tr, theRow, cell) { | |||
| ) { | |||
| cldrSurvey.appendExtraAttributes(cell, theRow); | |||
| } | |||
| if (CLDR_TABLE_DEBUG) { | |||
| if (CLDR_TABLE_DEBUG_ZOOM) { | |||
There was a problem hiding this comment.
If enabled, the first column gets "zoom{JSON}" links -- what are they for? They don't seem to accomplish anything with the current back end, and I don't find "r_rxt" or "rxt" in the current Java code. If this code is obsolete, let's delete it
There was a problem hiding this comment.
they were removed some time back.
| /* TODO: should load this locally via webpack, see https://unicode-org.atlassian.net/browse/CLDR-9195 */ | ||
| @import url("//fonts.googleapis.com/css?family=Noto+Sans:400italic,700italic,400,700"); | ||
| @import url("//fonts.googleapis.com/css?family=Noto+Sans+Symbols:400italic,700italic,400,700"); | ||
|
|
There was a problem hiding this comment.
The ancient ticket remains open and assigned to John: https://unicode-org.atlassian.net/browse/CLDR-9195
This change doesn't fix it but it does fix Chrome warnings that import statements need to be at the top of css
There was a problem hiding this comment.
we have webpack now, so this would be easier to do
| /* TODO: should load this locally via webpack, see https://unicode-org.atlassian.net/browse/CLDR-9195 */ | ||
| @import url("//fonts.googleapis.com/css?family=Noto+Sans:400italic,700italic,400,700"); | ||
| @import url("//fonts.googleapis.com/css?family=Noto+Sans+Symbols:400italic,700italic,400,700"); | ||
|
|
There was a problem hiding this comment.
The comment and imports aren't new, just moved to the top of the file
-Make cldrTable.CLDR_TABLE_DEBUG true; log times to console
-Make new cldrTable.CLDR_TABLE_DEBUG_ZOOM false; not clear whether still useful
-Fix Chrome warnings, add id locale-search-input and input-add-translation
-Fix Chrome warnings, move import statements to top of surveytool.css
-Comments
CLDR-17248
ALLOW_MANY_COMMITS=true