CLDR-17246 Muscogee locale data changes #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
macchiati
reviewed
Jan 10, 2024
common/main/mus.xml
Outdated
| <day type="mon">Enhvteceskv</day> | ||
| <day type="tue">Enhvteceskv Enhvyvtke</day> | ||
| <day type="wed">Ennvrkvpv</day> | ||
| <day type="thu">Ennvrkvpv Enhvyvtke</day> | ||
| <day type="fri">Nak Okkoskv Nettv</day> | ||
| <day type="sat">Nettv Cakcuse</day> | ||
| <day type="sat">Nettv cak'cuse</day> |
There was a problem hiding this comment.
This appears to be inconsistent titlecasing. Can you check?
Nak Okkoskv Nettv
vs
Nettv cak'cuse
|
Checking with Muscogee language folks on the casing differences...
…On Wed, Jan 10, 2024 at 9:59 AM Mark Davis ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In common/main/mus.xml
<#3390 (comment)>:
> <day type="mon">Enhvteceskv</day>
<day type="tue">Enhvteceskv Enhvyvtke</day>
<day type="wed">Ennvrkvpv</day>
<day type="thu">Ennvrkvpv Enhvyvtke</day>
<day type="fri">Nak Okkoskv Nettv</day>
- <day type="sat">Nettv Cakcuse</day>
+ <day type="sat">Nettv cak'cuse</day>
This appears to be inconsistent titlecasing. Can you check?
Nak Okkoskv Nettv
vs
Nettv cak'cuse
—
Reply to this email directly, view it on GitHub
<#3390 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATB6IZ7R47ML7UZ4FLZUKNLYN3JJ5AVCNFSM6AAAAAA7TOY4XGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMJTHAYDIMZRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@i18ncraig per today's meeting, you said you would fix the casing and then I can re-review |
First edit to this pull request and mus.xml file based on feedback from the Muscogee Nation. All weekdays should have initial caps. Saturday did not, so adding init caps for this day.
|
I have edited the pull request -- adding comments that per the Muscogee
Nation language program folks, days of the week should have init caps on
each word. Fixed accordingly. It has been a while since I've done PR edit,
so hope all is good.
…On Mon, Jan 22, 2024 at 2:05 PM Steven R. Loomis ***@***.***> wrote:
@i18ncraig <https://github.com/i18ncraig> per today's meeting, you said
you would fix the casing and then I can re-review
—
Reply to this email directly, view it on GitHub
<#3390 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATB6IZYQQ5KCLNX3FVZ636LYP3PEHAVCNFSM6AAAAAA7TOY4XGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUHEYDMMBXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
srl295
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17246
ALLOW_MANY_COMMITS=true