CLDR-16838 Follow-up, new optional CLDR_REDIRECT_PORT in cldr.properties #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Enable running with nginx on port other than default 80, flexibility for testing on local machine -No change in behavior if CLDR_REDIRECT_PORT not specified -Property is retrieved only once, then cached for performance
srl295
approved these changes
Nov 22, 2023
| String port = getRedirectPort(); | ||
| if (port != null) { | ||
| String url = | ||
| request.getScheme() + "://" + request.getServerName() + ":" + port + where; |
There was a problem hiding this comment.
how do you know what the scheme is?
couldn't this all just pull from CLDR_SURVEY_URL in the settings?
There was a problem hiding this comment.
maybe -- I didn't try that; I figured, like the original code, use the scheme and server name from the existing request, and just fix the port since that's what was broken when using 8888 for nginx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Enable running with nginx on port other than default 80, flexibility for testing on local machine
-No change in behavior if CLDR_REDIRECT_PORT not specified
-Property is retrieved only once, then cached for performance
CLDR-16838
ALLOW_MANY_COMMITS=true