CLDR-16838 Login bug; preliminary refactoring/debugging #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Add a temporary debugging boolean HARD_CODE_REDIRECT_PORT to enable testing locally with nginx on port 8888 -Delete dead code and fix compiler warnings in WebContext.java, SurveyMain.java, and related files -Remove the @deprecated label for the phase BETA since we still use it -Delete the other deprecated phases and dependent code -Add warning comments for methods that appear unused but are still accessed by jsp -Comments
btangmu
commented
Nov 7, 2023
| */ | ||
| @Deprecated | ||
| BETA("Beta", CheckCLDR.Phase.SUBMISSION); |
There was a problem hiding this comment.
We actually used BETA at the beginning of v44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add a temporary debugging boolean HARD_CODE_REDIRECT_PORT to enable testing locally with nginx on port 8888
-Delete dead code and fix compiler warnings in WebContext.java, SurveyMain.java, and related files
-Remove the Deprecated label for the phase BETA since we still use it
-Delete the other deprecated phases and dependent code
-Add warning comments for methods that appear unused but are still accessed by jsp
-Comments
CLDR-16838
ALLOW_MANY_COMMITS=true