-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17220 SBRS v45 merge selected maint/maint-44 fixes back to main #3373
CLDR-17220 SBRS v45 merge selected maint/maint-44 fixes back to main #3373
Conversation
…icode-org#3338) Adding missing variable in translation (cherry picked from commit bd50a7f)
Updates to modification section reflecting: - CLDR-16937 - CLDR-16038 - CLDR-16249 - CLDR-16251 (cherry picked from commit 06f64fc)
(cherry picked from commit be6a5c3)
…code-org#3341) (cherry picked from commit f581268)
(cherry picked from commit d331b75)
…code-org#3346) (cherry picked from commit 40d9939)
(cherry picked from commit d117e5a)
…unicode-org#3324) * CLDR-17153 Investigate discrepancy between growth and coverage charts * CLDR-17153 Cleanup (cherry picked from commit 3bea383)
(cherry picked from commit 7dbac53)
(cherry picked from commit 022ff3c)
…nicode-org#3359) - clarify that keyboard is a technical preview - fix typo in modification section (cherry picked from commit 0020703)
(cherry picked from commit e42c80c)
(cherry picked from commit bbb69f5)
(cherry picked from commit 9ffd5f7)
- charts broke with recent renames (such as to= to output=) (cherry picked from commit fa9259f)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I'm unfamiliar with most of this code
@@ -355,7 +456,7 @@ private static Map<String, FoundAndTotal> addGrowth( | |||
} | |||
// END HACK | |||
|
|||
if (showMissing) { | |||
if (false && showMissing) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dead code like this generally shouldn't be kept unless accompanied by an explanatory comment, preferably a TODO comment with an open ticket number, otherwise it leads to unmaintainable code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but fixing those kinds of things probably does not belong in this kind of PR which is just merging maint branch changes back to main as is.
CLDR-17220
This merges relevant fixes on the maint/maint-44 branch back to main. Notes:
We probably want to merge this with a Rebase and merge (temporarily enable in Settings) instead of the usual Squash and merge.
ALLOW_MANY_COMMITS=true
DISABLE_JIRA_ISSUE_MATCH=true