CLDR-17080 Regional Variants menu follow-up #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Set SIDEWAYS_DEBUG to false -Remove the 2-second delay if (and only if) the user has just chosen from the menu -Shorten excessively long functions by moving nested functions to top level and making more subroutines -Refactor for clarity -Comments
srl295
approved these changes
Nov 6, 2023
| @@ -8,27 +8,48 @@ import * as cldrLoad from "./cldrLoad.mjs"; | |||
| import * as cldrStatus from "./cldrStatus.mjs"; | |||
| import * as cldrSurvey from "./cldrSurvey.mjs"; | |||
|
|
|||
| const SIDEWAYS_DEBUG = true; | |||
| const SIDEWAYS_DEBUG = false; | |||
There was a problem hiding this comment.
yeah, this should be a .gitignored variable setting…
You know what we could do is have a separate .mjs file just for debugging settings. And then, you could use git skip to keep that file out of the PR.
Then in this file:
import * as cldrDebug from "./cldrDebug.mjs";
const SIDEWAYS_DEBUG = cldrDebug.get("SIDEWAYS_DEBUG");then you could do local tweaks without having to commit them.
There was a problem hiding this comment.
that's worth thinking about...
Comment on lines
+13
to
+14
| const NON_BREAKING_SPACES = "\u00A0\u00A0\u00A0"; // non-breaking spaces | ||
| const UNEQUALS_SIGN = "\u2260\u00A0"; // U+2260 = "≠" |
There was a problem hiding this comment.
perhaps this should go in cldrText? or in another common place
| * json.novalue, by assigning a value that's different from curValue. | ||
| */ | ||
| if (json.novalue) { | ||
| const differentValue = curValue === "A" ? "B" : "A"; // anything different from curValue |
There was a problem hiding this comment.
Suggested change
| const differentValue = curValue === "A" ? "B" : "A"; // anything different from curValue | |
| const differentValue = NaN; |
It'll never be === any other string. Or it could even be const differentvalue = Symbol("no value");
| const popupSelect = { | ||
| items: [], | ||
| label: | ||
| "Regional Variants for " + locmap.getRegionAndOrVariantName(topLocale), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Set SIDEWAYS_DEBUG to false
-Remove the 2-second delay if (and only if) the user has just chosen from the menu
-Shorten excessively long functions by moving nested functions to top level and making more subroutines
-Remove dependency of the Vue component on non-GUi modules cldrLoad, cldrStatus
-Refactor for clarity
-Comments
CLDR-17080
ALLOW_MANY_COMMITS=true