Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17171 v44 JSON: don't emit {} for space replacement #3358

Merged
merged 1 commit into from
Oct 23, 2023
Merged

CLDR-17171 v44 JSON: don't emit {} for space replacement #3358

merged 1 commit into from
Oct 23, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 23, 2023

CLDR-17171

  • Punt a better fix to CLDR-17186
  • ONLY fixes *SpaceReplacement elements

example:

diff --git a/cldr-json/cldr-person-names-modern/main/zh/personNames.json b/cldr-json/cldr-person-names-modern/main/zh/personNames.json
index 5f3ab58077..4263171e2c 100644
--- a/cldr-json/cldr-person-names-modern/main/zh/personNames.json
+++ b/cldr-json/cldr-person-names-modern/main/zh/personNames.json
@@ -21,7 +21,7 @@
         ],
         "formality": "informal",
         "length": "medium",
-        "nativeSpaceReplacement": {},
+        "nativeSpaceReplacement": "",
         "foreignSpaceReplacement": "·",
         "initial": "{0}",
         "initialSequence": "{0} {1}",
  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 requested review from sffc, btangmu and a team October 23, 2023 18:39
@srl295 srl295 self-assigned this Oct 23, 2023
@srl295
Copy link
Member Author

srl295 commented Oct 23, 2023

@Manishearth fyi

@srl295
Copy link
Member Author

srl295 commented Oct 23, 2023

Specifically this does NOT fix the vec issue - you'd still get "1901": {}, BUT v44 has already fixed the data for that.

That's why it's a punt.

@Manishearth
Copy link
Member

cc @echeran probably, I haven't been looking at the v44 stuff in ICU4X

@srl295 srl295 merged commit 9df3a18 into unicode-org:maint/maint-44 Oct 23, 2023
7 checks passed
@srl295 srl295 deleted the cldr-17171/json-fix-emptyval branch October 23, 2023 20:51
pedberg-icu pushed a commit to pedberg-icu/cldr that referenced this pull request Oct 31, 2023
@srl295 @pedberg-icu
CLDR-17171 v44 JSON: don't emit {} for space replacement (unicode-org…
f7c551c 
…#3358)

Punt a better fix to CLDR-17186

(cherry picked from commit 9df3a18)
pedberg-icu pushed a commit that referenced this pull request Nov 1, 2023
@srl295 @pedberg-icu
CLDR-17171 v44 JSON: don't emit {} for space replacement (#3358)
d1e2e10 
Punt a better fix to CLDR-17186

(cherry picked from commit 9df3a18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedberg-icu pedberg-icu pedberg-icu approved these changes

@sffc sffc Awaiting requested review from sffc

@btangmu btangmu Awaiting requested review from btangmu

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srl295 @Manishearth @pedberg-icu