-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-16251 Add constraint on duplicate variant tags #3323
CLDR-16251 Add constraint on duplicate variant tags #3323
Conversation
Going ahead and merging this... |
> As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there is a further condition: | ||
> The sequence of variant subtags must not have any duplicates (eg, de-1996-fonipa-1996 is not syntactically well-formed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there is a further condition: | |
> The sequence of variant subtags must not have any duplicates (eg, de-1996-fonipa-1996 is not syntactically well-formed). | |
As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there is a further condition: | |
The sequence of variant subtags must not have any duplicates (eg, de-1996-fonipa-1996 is not syntactically well-formed). |
(and for consistency with Unicode Locale Identifier, this should probably precede the grammar table)
> As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there is a further condition: | ||
> The sequence of variant subtags in a tlang must not have any duplicates. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be merged with the comment above the table, e.g.
-As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there is a further condition: There cannot be more than one extension with the same singleton (-a-, …, -t-, -u-, …). Note that the private use extension (-x-) must come after all other extensions.
+As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there are further conditions:
+There cannot be more than one extension with the same singleton (-a-, …, -t-, -u-, …), and
+the sequence of variant subtags in a tlang must not have any duplicates.
+Note that the private use extension (-x-) must come after all other extensions, and can be followed by any subtags.
@macchiati Note the above comments, which were submitted just after merge and therefore weren't addressed. |
@gibson042 @macchiati I filed https://unicode-org.atlassian.net/browse/CLDR-17211 to address those post-merge comments. |
CLDR-16251
ALLOW_MANY_COMMITS=true