Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16251 Add constraint on duplicate variant tags #3323

Conversation

macchiati
Copy link
Member

CLDR-16251

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@pedberg-icu
Copy link
Contributor

Going ahead and merging this...

@pedberg-icu pedberg-icu merged commit 873ab68 into unicode-org:main Oct 5, 2023
4 checks passed
Comment on lines +320 to +321
> As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there is a further condition:
> The sequence of variant subtags must not have any duplicates (eg, de-1996-fonipa-1996 is not syntactically well-formed).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there is a further condition:
> The sequence of variant subtags must not have any duplicates (eg, de-1996-fonipa-1996 is not syntactically well-formed).
As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there is a further condition:
The sequence of variant subtags must not have any duplicates (eg, de-1996-fonipa-1996 is not syntactically well-formed).

(and for consistency with Unicode Locale Identifier, this should probably precede the grammar table)

Comment on lines +353 to +355
> As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there is a further condition:
> The sequence of variant subtags in a tlang must not have any duplicates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be merged with the comment above the table, e.g.

-As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there is a further condition: There cannot be more than one extension with the same singleton (-a-, …, -t-, -u-, …). Note that the private use extension (-x-) must come after all other extensions.
+As is often the case, the complete syntactic constraints are not easily captured by ABNF, so there are further conditions:
+There cannot be more than one extension with the same singleton (-a-, …, -t-, -u-, …), and
+the sequence of variant subtags in a tlang must not have any duplicates.
+Note that the private use extension (-x-) must come after all other extensions, and can be followed by any subtags.

@gibson042
Copy link
Contributor

@macchiati Note the above comments, which were submitted just after merge and therefore weren't addressed.

@pedberg-icu
Copy link
Contributor

@macchiati Note the above comments, which were submitted just after merge and therefore weren't addressed.

@gibson042 @macchiati I filed https://unicode-org.atlassian.net/browse/CLDR-17211 to address those post-merge comments.

@macchiati macchiati deleted the CLDR-16251-Add-constraint-on-duplicate-variant-tags branch April 3, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants