Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17113 kbd: element/attr renaming #3313

Merged
merged 7 commits into from
Oct 11, 2023
Merged

CLDR-17113 kbd: element/attr renaming #3313

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77a7f16
CLDR-17113 kbd: element/attr renaming
srl295 Oct 3, 2023
053d458
CLDR-17113 kbd display output= and display= should support variables
srl295 Oct 5, 2023
24f19c8
CLDR-17113 kbd shuffle element deck chairs
srl295 Oct 9, 2023
a0ee437
CLDR-17113 kbd: move keyList back into attributes
srl295 Oct 10, 2023
2ddc18a
CLDR-17113 kbd: add longPressDefaultKeyId
srl295 Oct 10, 2023
490827f
CLDR-17113 kbd: no nested gestures
srl295 Oct 11, 2023
846982c
CLDR-17113 kbd: no nested gestures,2
srl295 Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/ldml/tr35-keyboards.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,8 @@ _Attribute:_ `longPressKeyIds="{list of key ids}"` (optional)
>
> In a list of keys specified by `longPressKeyIds`, the key matching `longPressDefaultKeyId` attribute (if present) specifies the default long-press target, which could be different than the first element. It is an error if the `longPressDefaultKeyId` key is not in the `longPressKeyIds` list.
>
> Gestures are not nested: other gestures (such as flick, multiTap, longPress) are ignored on the keys in the `longPressKeyIds` list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like before, do not use "are" and similar factual statements. It is unclear who they target and what they mean. Say "Implementations may ignore/not support" or shall not or whatever is appropriate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well put. I will revise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

>
> For example, if the default key is a key whose [display](#Element_displays) value is `{`, an implementation might render the key as follows:
>
> ![keycap hint](images/keycapHint.png)
Expand Down Expand Up @@ -696,6 +698,8 @@ _Attribute:_ `multiTapKeyIds` (optional)
> A space-separated ordered list of `key` element ids, which keys, where each successive key in the list is produced by the corresponding number of quick taps.
> It is an error for a key to reference itself in the `multiTapKeyIds` list.
>
> Gestures are not nested: other gestures (such as flick, multiTap, longPress) are ignored on the keys in the `multiTapKeyIds` list.
>
> _Example:_
> - first tap on the key will produce “a”
> - two taps will produce “bb”
Expand Down Expand Up @@ -925,6 +929,9 @@ _Attribute:_ `directions` (required)
_Attribute:_ `keyId` (required)

> The `keyId` attribute value is the result of (one or more) flicks.
>
> Gestures are not nested: other gestures (such as flick, multiTap, longPress) are ignored on the key referenced by `keyId`.


**Example**
where a flick to the Northeast then South produces `Å`.
Expand Down