Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17091 kbd: move names into info name="…" #3310

Merged
merged 1 commit into from
Oct 9, 2023
Merged

CLDR-17091 kbd: move names into info name="…" #3310

merged 1 commit into from
Oct 9, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 3, 2023 •
edited
Loading

  • drop the element
  • make required
  • add as a required attribute
  • update docs and dtd

CLDR-17091

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true
DISABLE_JIRA_ISSUE_MATCH=true

@srl295 srl295 added the keyboard label Oct 3, 2023
@srl295 srl295 requested review from miloush and a team October 3, 2023 22:08
@srl295 srl295 self-assigned this Oct 3, 2023
mcdurdin
mcdurdin previously approved these changes Oct 4, 2023
View reviewed changes
@srl295 srl295 force-pushed the srl295/kbd/cldr-17092-settings branch from 98628f9 to 1cb143e Compare October 4, 2023 15:13
@srl295 srl295 requested review from a team October 4, 2023 15:15
@srl295 srl295 force-pushed the srl295/kbd/cldr-17091-name branch from 31c6c9d to d609b29 Compare October 4, 2023 15:18
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

miloush
miloush reviewed Oct 5, 2023
View reviewed changes
docs/ldml/tr35-keyboards.md Outdated

> This is the only required attribute.
>
> This name is not localized, but is an informative name for the keyboard.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say not localized, does that mean it is in the primary locale of the keyboard? Or English? Or arbitrary locale of choice of the author?

Not sure why there is but here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take out 'but', and 'not localized' doesn't add a lot here. It was meant to say that there weren't multiple names per language for the keyboard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you raised a good point. If not giving guidance to authors, we should at least have agreed understanding of what do we expect people to put here in terms of language.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could say 'this name may be in the primary language of the keyboard' or something? Bulgarian (Phonetic Traditional) isn't a great example then.

Base automatically changed from srl295/kbd/cldr-17092-settings to main October 5, 2023 15:29
@srl295 srl295 dismissed mcdurdin’s stale review October 5, 2023 15:29

The base branch was changed.

srl295
srl295 commented Oct 5, 2023
View reviewed changes
docs/ldml/tr35-keyboards.md
> This is the only required attribute.
>
> This name is not localized, but is an informative name for the keyboard.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take out 'but', and 'not localized' doesn't add a lot here. It was meant to say that there weren't multiple names for the keyboard according to different languages.

@srl295
Copy link
Member Author

srl295 commented Oct 7, 2023 •
edited
Loading

@miloush @mcdurdin thoughts?

Idea, if the DTD is right and there are just minor editorial changes, perhaps those could go in a later PR (though soon)? I'd like ot get the major spec changes, such as dropping <names> in

@srl295 srl295 requested a review from a team October 7, 2023 16:29
miloush
miloush previously approved these changes Oct 7, 2023
View reviewed changes
@srl295
CLDR-17091 kbd: move names into info name="…"
29af7f2 
- drop the <names> element
- make <info> required
- add <info name="…"> as a required attribute
- update docs and dtd
- test fix for XML validity
- update the info name= attribute
@srl295 srl295 force-pushed the srl295/kbd/cldr-17091-name branch from c8f2fec to 29af7f2 Compare October 8, 2023 01:32
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • keyboards/dtd/ldmlKeyboard.dtd is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member Author

srl295 commented Oct 8, 2023

Sorry, need another rubber stamp.

You can see from the link that there's no real change. But somehow the merge from main didn't work properly.

@srl295
Copy link
Member Author

srl295 commented Oct 8, 2023

merge-from-main didn't seem to work well here.

@srl295 srl295 merged commit fcba89b into main Oct 9, 2023
8 of 10 checks passed
@srl295 srl295 deleted the srl295/kbd/cldr-17091-name branch October 9, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloush miloush miloush approved these changes

@mcdurdin mcdurdin mcdurdin approved these changes

Assignees

@srl295 srl295

Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srl295 @mcdurdin @miloush