Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17126 Update CLDR segment tailorings to reflect ICU 74 word break changes #3289

Conversation

pedberg-icu
Copy link
Contributor

CLDR-17126

  • This PR completes the ticket.

Update CLDR segmentation tailorings to reflect word break tailorings updates in ICU 74 (CLDR 44 did not make any tailoring updates that need to be synced to ICU).

ALLOW_MANY_COMMITS=true

@srl295
Copy link
Member

srl295 commented Sep 28, 2023

Can we get a link to a ticket with the ICU side changes and rationale? (probably should go in this ticket)

@pedberg-icu
Copy link
Contributor Author

pedberg-icu commented Sep 28, 2023

Can we get a link to a ticket with the ICU side changes and rationale? (probably should go in this ticket)

The relevant ICU tickets are:

  • First ICU-22112 word break updates for @,colon; colon tailorings for fi,sv
  • Then ICU-22360 revert portions of ICU-22112 which included @ in ALetter for wordbreak, update tests

I will add this to the ticket as well.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@eggrobin

@eggrobin
Copy link
Member

Scripsit @markusicu

@eggrobin

Should we upstream these root tailorings to UAX29? (In which case a PAG issue needs to be filed; at a glance we would probably do that by changing the Word_Break property of the characters involved, though I would need to look at the context more closely to summarize it for a recommendation.)

@pedberg-icu pedberg-icu merged commit 31aa6d9 into unicode-org:main Sep 28, 2023
@markusicu
Copy link
Member

Should we upstream these root tailorings to UAX29? (In which case a PAG issue needs to be filed; at a glance we would probably do that by changing the Word_Break property of the characters involved, though I would need to look at the context more closely to summarize it for a recommendation.)

--> https://github.com/unicode-org/properties/issues/187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants