Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16604 kbd: jis scancodes incorrect #3282

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 25, 2023

CLDR-16604

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true
DISABLE_JIRA_ISSUE_MATCH=true

found in review of keymanapp/keyman#9615

@srl295 srl295 self-assigned this Sep 25, 2023
@srl295 srl295 requested review from mcdurdin, miloush and a team September 25, 2023 21:32
@srl295 srl295 changed the title CLDR-16604: kbd: jis scancodes incorrect CLDR-16604 kbd: jis scancodes incorrect Sep 25, 2023
@srl295 srl295 changed the title CLDR-16604: kbd: jis scancodes incorrect CLDR-16604 kbd: jis scancodes incorrect Sep 25, 2023
mcdurdin
mcdurdin previously approved these changes Sep 25, 2023
@miloush
Copy link
Contributor

miloush commented Sep 25, 2023

The standard btw. is available here: https://www.shoshin.co.jp/c/cons/oadg/oadghwd.pdf. Physical layouts starting on p. 274.

For 109A and all the others:
image

None of them has the physical key that would be number 45. I confirm the Japanese hardware I have also does not have it. It is however, reserved to the expected scancode (p. 286):

image

miloush
miloush previously approved these changes Sep 25, 2023
srl295 added a commit that referenced this pull request Sep 25, 2023
@srl295 srl295 force-pushed the cldr-16604/kbd/scancodesfix branch from 930fde0 to e574254 Compare September 25, 2023 23:47
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@miloush
Copy link
Contributor

miloush commented Sep 26, 2023

However, the Korean I belive is KS X 5003:2001 (confirmed 2021). That is available at https://e-ks.kr/streamdocs/view/sd;streamdocsId=72059288176667875. Key numbers p. 9, scan code mapping p. 15. As far as I can tell, the key next to backspace should not be 7D but 2B (with the second row having only 12 keys):

image

image

Sadly I don't have any Korean hardware myself at the moment, although I can see you can buy both one-row- and two-row-enter keyboards (but also ones missing that key completely), and I suspect the former would have 7D and the latter 2B next to the backspace . Poor people.

If we want to have an explicit Korean form I would tend to follow the standard. The other option is already covered by the jis form.

@srl295 srl295 dismissed stale reviews from miloush and mcdurdin via 2d20601 September 27, 2023 00:49
@srl295
Copy link
Member Author

srl295 commented Sep 27, 2023

@mcdurdin backslash again ^

@miloush PTAL

@srl295 srl295 force-pushed the cldr-16604/kbd/scancodesfix branch from 2d20601 to 97c0103 Compare September 27, 2023 18:35
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 merged commit de60afc into main Sep 27, 2023
@srl295 srl295 deleted the cldr-16604/kbd/scancodesfix branch September 27, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants