-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-15595 Reserve strings "undefined", "undefine", and "auto" in LDML #3278
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text LGTM but I think it's in the wrong place, put it under #Valid_Attribute_Values
Also There Oughtta Be A Test™, under |
@sffc ping? |
This seems like a tricky test to write. I need to figure out how to check the full set of identifiers. |
see the |
That class can be used to iterate through all of the elements and all of
their attributes, and check if any value, like " undefined" is valid.
…On Fri, Oct 6, 2023, 17:24 Steven R. Loomis ***@***.***> wrote:
This seems like a tricky test to write. I need to figure out how to check
the full set of identifiers.
see the DtdData class
—
Reply to this email directly, view it on GitHub
<#3278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMC4X7D5UCPK5WZVJLDX6APDZAVCNFSM6AAAAAA5AQLDQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQHA4TIMRVGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
@@ -242,6 +242,14 @@ External specifications may also reference particular components of Unicode loca | |||
|
|||
> _Field X can contain any Unicode region subtag values as given in Unicode Technical Standard #35: Unicode Locale Data Markup Language (LDML), excluding grouping codes._ | |||
|
|||
### <a name="String_Identifiers" href="#String_Identifiers">String Identifiers</a> | |||
|
|||
Unicode LDML specifies many enumerations of string identifiers, such as days of the week ("`mon"`, `"tue"`, …), units of measurement (`"meter"`, `"inch"`, …), and person name fields (`"title"`, `"given"`, …). For any such string enumeration, the following identifiers are reserved for use by implementations and will not be added as explicit entries into the enumeration by LDML: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "specifies many enumerations" is too vague to be normative.
One way to more completely specify it would be to restrict it to attribute values. That is, however, too broad, because attributes can be representing other information. Or maybe focus on the terms that can be in bcp47 subtags?
One way to make progress in v44 would be to explicitly list those enumerations that cannot contain these terms, and then in v45 work on a more general solution.
So you have confirmed that the DTD doesn't currently use these terms? Do we need to also check the data that there’s not some data element, such as a calendar or unit with I agree that if we're confident we're not already in violation of the requirement, this could proceed into the spec. ( i still think it should be located under |
So you have confirmed that the DTD doesn't currently use these terms?
No, I've confirmed something quite different: that we have *no* guarantees
in the DTD that those terms *cannot* be used. (That is, there are @match
values that permit them.)
It would be possible to make a test that no current (and past?) CLDR data
had values in {define, defined, auto}. One slight complication would be
that the multivalue attributes would need to split the values to check.
…On Mon, Oct 9, 2023 at 4:17 PM Steven R. Loomis ***@***.***> wrote:
I made a quick program to do a test for that, but we would need to enhance
the @match <https://github.com/match> values further before it could be a
useful test. (#3328 <#3328>)
So that should not stand in the way of this PR.
So you have confirmed that the DTD doesn't currently use these terms?
Do we need to also check the data that there’s not some data element, such
as a calendar or unit with <type name="undefine" … ?
I agree that if we're confident we're not already in violation of the
requirement, this could proceed into the spec.
( i still think it should be located under #Valid_Attribute_Values though
)
—
Reply to this email directly, view it on GitHub
<#3278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMHLDZ2HLQNVGOYCCLTX6QBQZAVCNFSM6AAAAAA5AQLDQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTGEYDEMBWGU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
CLDR-15595
This change describes all of LDML, so I wasn't sure exactly where to put it, so I made a spot for it in the top-level tr35.md.