-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-7277 Parallel ConsoleCheck #3154
CLDR-7277 Parallel ConsoleCheck #3154
Conversation
TestCache testCache = new TestCache(); // for parallelism | ||
testCache.setFactory(cldrFactory, checkFilter); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the core change: use TestCache (same as ST! ) to manage the CheckCLDR instances.
This does have an added benefit that we're running more similar code in ConsoleCheck and ST… I don't anticipate divergence otherwise, but it does mean the environ is similar.
about 2x improvement, could be improved especially when targetting batch mode
- new option "-1" to request sequential console check - runs in sequential mode under certain circumstances - also, added CheckCLDR.toString() to just show a simple class name
3996ea7
to
8e2ef1c
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
should be feature-complete. i'm not sure how to use the html and example features, but it should call the same code as before. |
Hrm, this might conflict with CLDR-17289 somehow. |
"might conflict with CLDR-17289 somehow" -- it shouldn't be a problematic merge conflict if that's what you mean -- only one file in common, CheckCLDR.java, and only a few lines or do you mean a conflict in some other sense? |
Just being cautious. Somehow i thought this was merged but it wasn't. This would be great to get in, brings a bit of a speedup. |
|
||
subtotalCount.clear(); | ||
if (CLDRFile.isSupplementalName(localeID)) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check to see if CLDRFile.isSupplementalName should be used anymore. It is a holdover from when the supplemental data files were in the same folder as the locale-based files (en.xml, etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=> CLDR-17291
about 2x improvement, could be improved even more especially when targetting batch (non-interactive) mode
CLDR-7277
ALLOW_MANY_COMMITS=true