Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-15034 kbd: move pcm keyboard to 3.0 format #3123

Merged
merged 6 commits into from
Sep 21, 2023
Merged

CLDR-15034 kbd: move pcm keyboard to 3.0 format #3123

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa62879
CLDR-15034 kbd: move pcm keyboard to 3.0 format
srl295 Jul 30, 2023
0592524
CLDR-15034 kbd: update to pcm keyboard
srl295 Aug 24, 2023
956d4ed
CLDR-15034 Merge remote-tracking branch 'upstream/main' into kbd/pcm2
srl295 Sep 20, 2023
faa52cd
CLDR-15034 update to Keyboard3
srl295 Sep 20, 2023
f2c680d
CLDR-15034 kbd: pcm: apply review comments
srl295 Sep 20, 2023
92d147c
CLDR-15034 update to Keyboard3 (stray commit)
srl295 Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions keyboards/3.0/pcm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE keyboard SYSTEM '../dtd/ldmlKeyboard.dtd'>
<keyboard locale="pcm" conformsTo="techpreview">
<version number="1.0.0" />
<names>
<name value="Nigerian Pidgin" />
<name value="Naijíriá Píjin" />
</names>
<settings fallback="omit" />
<keys>
<import base="cldr" path="techpreview/keys-Zyyy-punctuation.xml" />
<import base="cldr" path="techpreview/keys-Zyyy-currency.xml" />
<key id="grave" to="\u{300}" />
<key id="acute" to="\u{301}" />

<!-- accented vowels -->
<key id="odot" to="ọ" />
<key id="Odot" to="Ọ" />
<key id="edot" to="ẹ" />
<key id="Edot" to="Ẹ" />

<!-- currency -->
<key id="naira" to="₦" />
</keys>

<layers form="iso">
<layer modifier="none">
<row keys="grave 1 2 3 4 5 6 7 8 9 0 hyphen equal" />
<row keys="acute w e r t y u i o p open-square close-square" />
<row keys="a s d f g h j k l odot edot slash" />
<row keys="slash z c v b n m comma period semi-colon apos" />
<row keys="space" />
</layer>

<layer modifier="shift">
<row keys="grave bang at hash dollar naira percent amp asterisk open-paren close-paren underscore plus" />
<row keys="acute W E R T Y U I O P open-curly close-curly" />
<row keys="A S D F G H J K L Odot Edot" />
srl295 marked this conversation as resolved.
Show resolved Hide resolved
<row keys="question Z C V B N M open-angle close-angle colon double-quote" />
<row keys="space" />
</layer>

<layer modifier="caps">
<row keys="grave 1 2 3 4 5 6 7 8 9 0 hyphen equal" />
srl295 marked this conversation as resolved.
Show resolved Hide resolved
<row keys="acute W E R T Y U I O P open-square close-square" />
srl295 marked this conversation as resolved.
Show resolved Hide resolved
<row keys="A S D F G H J K L Odot Edot slash" />
<row keys="slash Z C V B N M comma period semi-colon apos" />
<row keys="space" />
</layer>

</layers>

<transforms type="simple">
<transformGroup>
<transform from="''" to="\u{323}" /> <!-- Quick way to add dot below -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this apos? I wonder how intuitive it is to have all these as implicit import

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't an implicit import. this is a double apostrophe, as in the original file.

</transformGroup>
</transforms>
</keyboard>
21 changes: 21 additions & 0 deletions keyboards/test/pcm-test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE keyboardTest SYSTEM "../dtd/ldmlKeyboardTest.dtd">
<keyboardTest conformsTo="techpreview">
<info keyboard="pcm.xml" author="Team Keyboard" name="pcm-test" />
<repertoire name="simple-repertoire" chars="[a b c d e ọ Ọ ẹ Ẹ ₦]" type="simple" />
<tests name="key-tests">
<test name="abc-test">
<startContext to="abc" />
<keystroke key="d" />
<check result="abcd" />
</test>
<test name="dot-below-test">
<startContext to="" />
<keystroke key="e" />
<keystroke key="apos" />
<check result="e'" />
<keystroke key="apos" />
<check result="e\u{323}" />
</test>
</tests>
</keyboardTest>