Skip to content

Commit

Permalink
CLDR-16853 remove raw URLs from checks, handle via subtype map (#3663)
Browse files Browse the repository at this point in the history
  • Loading branch information
srl295 authored May 2, 2024
1 parent 0ce3fdd commit f1242b4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,7 @@ public CheckCLDR handleCheck(

Matcher matcher = null;
String message =
"Can't have same translation as {0}. Please change either this name or the other one. "
+ "See <a target='doc' href='http://cldr.unicode.org/translation/short-names-and-keywords#TOC-Unique-Names'>Unique-Names</a>.";
"Can't have same translation as {0}. Please change either this name or the other one.";
Matcher currentAttributesToIgnore = ignoreAltAndCountAttributes;
Set<String> paths;
if (myType == Type.DECIMAL_FORMAT) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -268,10 +268,7 @@ private void addFailure(List<CheckStatus> result, Failure failure) {
.setSubtype(Subtype.sameAsEnglish)
.setCheckOnSubmit(false)
.setMessage(
"The value is the same as in English: see <a target='CLDR-ST-DOCS' href='"
+ CLDRURLS.ERRORS_URL
+ "'>Fixing Errors and Warnings</a>.",
new Object[] {}));
"The value is the same as in English.", new Object[] {}));
break;
case same_as_code:
result.add(
Expand All @@ -281,10 +278,7 @@ private void addFailure(List<CheckStatus> result, Failure failure) {
.setSubtype(Subtype.sameAsCode)
.setCheckOnSubmit(false)
.setMessage(
"The value is the same as the 'code': see <a target='CLDR-ST-DOCS' href='"
+ CLDRURLS.ERRORS_URL
+ "'>Fixing Errors and Warnings</a>.",
new Object[] {}));
"The value is the same as the 'code'.", new Object[] {}));
break;
default:
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -851,13 +851,7 @@ private void addMissingMessage(
}
scriptString.append("}");
}
final String helpUrl =
"http://cldr.unicode.org/translation/-core-data/exemplars#TOC-Handling-Warnings-in-Exemplar-characters";
final String message =
"The characters \u200E{0}\u200E {1} {2}. "
+ "For what to do, see <i>Handling Warnings</i> in <a target='CLDR-ST-DOCS' href='"
+ helpUrl
+ "'>Exemplar Characters</a>.";
final String message = "The characters \u200E{0}\u200E {1} {2}.";
result.add(
new CheckStatus()
.setCause(this)
Expand Down

0 comments on commit f1242b4

Please sign in to comment.